You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "szafonimateusz-mi (via GitHub)" <gi...@apache.org> on 2026/09/02 14:25:15 UTC
[PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
szafonimateusz-mi opened a new pull request, #20046:
URL: https://github.com/apache/nuttx/pull/20046
## Summary
Fix work_cancel() to return -ENOENT when no such work is queued
## Impact
required to pass intel64 LTP tests
## Testing
NTFC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20046:
URL: https://github.com/apache/nuttx/pull/20046#issuecomment-5512257820
<!-- membrowse-pr-comment -->
## <img src="https://membrowse.com/membrowse-logo.svg" height="24" align="top"> MemBrowse Memory Report
*No memory changes detected for:*
- [arduino-mega2560](https://membrowse.com/public/apache/nuttx/target/arduino-mega2560/compare?head=4f1b3f370c0cff8a62ac7ca7eecfae0cc703f1aa&base=83b4239e1d780c58ddf55f7533f6ca49dbddba73)
- [esp32-devkitc](https://membrowse.com/public/apache/nuttx/target/esp32-devkitc/compare?head=4f1b3f370c0cff8a62ac7ca7eecfae0cc703f1aa&base=83b4239e1d780c58ddf55f7533f6ca49dbddba73)
- [hifive1-revb](https://membrowse.com/public/apache/nuttx/target/hifive1-revb/compare?head=4f1b3f370c0cff8a62ac7ca7eecfae0cc703f1aa&base=83b4239e1d780c58ddf55f7533f6ca49dbddba73)
- [mirtoo](https://membrowse.com/public/apache/nuttx/target/mirtoo/compare?head=4f1b3f370c0cff8a62ac7ca7eecfae0cc703f1aa&base=83b4239e1d780c58ddf55f7533f6ca49dbddba73)
- [qemu-intel64](https://membrowse.com/public/apache/nuttx/target/qemu-intel64/compare?head=4f1b3f370c0cff8a62ac7ca7eecfae0cc703f1aa&base=83b4239e1d780c58ddf55f7533f6ca49dbddba73)
- [rx65n-rsk2mb](https://membrowse.com/public/apache/nuttx/target/rx65n-rsk2mb/compare?head=4f1b3f370c0cff8a62ac7ca7eecfae0cc703f1aa&base=83b4239e1d780c58ddf55f7533f6ca49dbddba73)
- [s698pm-dkit](https://membrowse.com/public/apache/nuttx/target/s698pm-dkit/compare?head=4f1b3f370c0cff8a62ac7ca7eecfae0cc703f1aa&base=83b4239e1d780c58ddf55f7533f6ca49dbddba73)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #20046:
URL: https://github.com/apache/nuttx/pull/20046#discussion_r3915976766
##########
sched/wqueue/kwork_cancel.c:
##########
@@ -71,6 +71,10 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue, bool sync,
work_timer_reset(wqueue);
}
}
+ else
+ {
+ ret = -ENOENT;
Review Comment:
but no ret variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl closed pull request #20046: sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued
URL: https://github.com/apache/nuttx/pull/20046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #20046:
URL: https://github.com/apache/nuttx/pull/20046#discussion_r3917894070
##########
sched/wqueue/kwork_cancel.c:
##########
@@ -71,6 +72,10 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue, bool sync,
work_timer_reset(wqueue);
}
}
+ else
+ {
+ ret = -ENOENT;
Review Comment:
why not return, but to through the remaining code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #20046:
URL: https://github.com/apache/nuttx/pull/20046#discussion_r3921862591
##########
sched/wqueue/kwork_cancel.c:
##########
@@ -71,6 +72,10 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue, bool sync,
work_timer_reset(wqueue);
}
}
+ else
+ {
+ ret = -ENOENT;
Review Comment:
early return will change the behavior of this function for sync path. I haven't analyzed the consequences of this, so no early return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #20046:
URL: https://github.com/apache/nuttx/pull/20046#issuecomment-5566252938
I'll keep this change in https://github.com/apache/nuttx/pull/20030 until all tests pass on intel64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #20046:
URL: https://github.com/apache/nuttx/pull/20046#discussion_r3925695694
##########
sched/wqueue/kwork_cancel.c:
##########
@@ -71,6 +72,10 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue, bool sync,
work_timer_reset(wqueue);
}
}
+ else
+ {
+ ret = -ENOENT;
Review Comment:
ok, but why return -ENOENT in this case? it's fine to return OK if work isn't queued yet since the final result is that the work doesn't fire anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org