You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/27 01:28:12 UTC
[jira] [Commented] (BEAM-199) Improve fluent interface for
manipulating DisplayData.Items
[ https://issues.apache.org/jira/browse/BEAM-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259167#comment-15259167 ]
ASF GitHub Bot commented on BEAM-199:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/247
[BEAM-199] Update DisplayData APIs to make overrides more understandable
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam displaydata-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #247
----
commit 6a63fc6dd536be49971dc4987cc0d0ab3f887829
Author: Scott Wegner <sw...@google.com>
Date: 2016-04-25T23:04:38Z
Change API to register DisplayData items to make overrides more understandable
----
> Improve fluent interface for manipulating DisplayData.Items
> -----------------------------------------------------------
>
> Key: BEAM-199
> URL: https://issues.apache.org/jira/browse/BEAM-199
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
>
> See discussion [here|https://github.com/apache/incubator-beam/pull/126#discussion_r59785549]. The current fluent API may be difficult to use and could cause some ambiguity. We have some ideas in the linked thread on how to improve it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)