You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "brandonfl (via GitHub)" <gi...@apache.org> on 2023/12/17 15:00:30 UTC

[PR] Migration of the project to a multi-module project [commons-email]

brandonfl opened a new pull request, #191:
URL: https://github.com/apache/commons-email/pull/191

   Here is the PR to migrate the mono-module to a multi-module that is the requirement for the [EMAIL-203](https://issues.apache.org/jira/browse/EMAIL-203)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859206353

   @sebbASF I have fixed the issue, conf file on the wrong package
   
   Now I have this error in local : 
   
   ```
   Too many files with unapproved license: 102 See RAT report
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859195981

   @garydgregory Will add the Jakarta module on a second PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859212585

   @sebbASF @garydgregory 
   
   Errors fixed, build success with command 
   
   ```
   mvn --show-version --batch-mode --no-transfer-progress -Ddoclint=all
   ``` 
   
   <img width="627" alt="Capture d’écran 2023-12-17 à 17 10 07" src="https://github.com/apache/commons-email/assets/25805069/5ae17223-2064-4242-acaf-95e5fd3b3e9c">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859213060

   Np for the release, I will update the branche when release done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859210855

   @sebbASF ok the command 
   
   ```
   mvn --show-version --batch-mode --no-transfer-progress -Ddoclint=all
   ``` 
   
   also give me the RAT error on the master branche making me need to use `-Drat.skip=true` on master branch too
   
   is that normal ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.

garydgregory commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859212252

   IMO, this is a waste of time and effort since 1.6.0 is not out yet and I am still preparing for a release candidate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl closed pull request #191: Migration of the project to a multi-module project
URL: https://github.com/apache/commons-email/pull/191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.

sebbASF commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859203493

   > checking for the errors, strange since i dont have them on local 🤔
   
   I suspect the RAT excludes in pom.xml may need to be adjusted for the new layout


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1869560196

   Closing as the multi-module migration is now present on master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Migration of the project to a multi-module project [commons-email]

Posted by "brandonfl (via GitHub)" <gi...@apache.org>.

brandonfl commented on PR #191:
URL: https://github.com/apache/commons-email/pull/191#issuecomment-1859202342

   checking for the errors, strange since i dont have them on local 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org