You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/04/29 17:11:25 UTC
[GitHub] [maven-common-artifact-filters] cstamas opened a new pull request #17: Sanitize dependencies
cstamas opened a new pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17
Double artifacts (org.eclipse.aether vs maven-resolver) and other.
Removed them and it just works.
Reordered properties, removed superfluous dependencies.
Used snapshot version for maven-shared-utils:3.3.5-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on a change in pull request #17: [MSHARED-988] Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623737879
##########
File path: src/main/java/org/apache/maven/shared/artifact/filter/ScopeArtifactFilter.java
##########
@@ -25,7 +25,7 @@
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.DefaultArtifact;
import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
-import org.codehaus.plexus.logging.Logger;
+import org.slf4j.Logger;
Review comment:
https://github.com/apache/maven-common-artifact-filters/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on pull request #17: [MSHARED-988] Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#issuecomment-830027875
superseded by these
* https://github.com/apache/maven-common-artifact-filters/pull/18
* https://github.com/apache/maven-common-artifact-filters/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas closed pull request #17: [MSHARED-988] Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas closed pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas edited a comment on pull request #17: Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#issuecomment-829442072
Setting maven-* artifacts to provided may affect consumers, so I may revert that change. Still, the presence of maven-plugin-api _assumes_ this artifact is consumed *only by plugins*?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on a change in pull request #17: Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623340569
##########
File path: pom.xml
##########
@@ -55,9 +55,9 @@
</distributionManagement>
<properties>
- <maven.version>3.1.1</maven.version>
<javaVersion>7</javaVersion>
- <aether.version>0.9.0.M2</aether.version>
+ <maven.version>3.1.1</maven.version>
+ <resolver.version>1.6.2</resolver.version>
Review comment:
resolver should be binary compatible, at least the used bits, but we can lower if really needed (hopefully not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on a change in pull request #17: [MSHARED-988] Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623740816
##########
File path: pom.xml
##########
@@ -98,59 +98,51 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
+
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.6</version>
</dependency>
- <dependency>
- <groupId>org.eclipse.aether</groupId>
- <artifactId>aether-api</artifactId>
- <version>${aether.version}</version>
- </dependency>
- <dependency>
- <groupId>org.eclipse.aether</groupId>
- <artifactId>aether-util</artifactId>
- <version>${aether.version}</version>
- </dependency>
- <dependency>
- <groupId>org.eclipse.sisu</groupId>
- <artifactId>org.eclipse.sisu.plexus</artifactId>
- <version>0.0.0.M5</version>
- </dependency>
+
+
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.2</version>
+ <version>${resolver.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-util</artifactId>
- <version>1.4.2</version>
+ <version>${resolver.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
- <version>3.3.3</version>
+ <version>4.0.0-SNAPSHOT</version>
Review comment:
@elharo I still used snapshot, as IMO this PR should wait for https://github.com/apache/maven-shared-utils/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on pull request #17: Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#issuecomment-829442072
Setting maven-* artifacts to provided may affect consumers, so I may revert. Still, the presence of maven-plugin-api _assumes_ this artifact is consumed *only by plugins*?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] slachiewicz commented on a change in pull request #17: Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623331483
##########
File path: pom.xml
##########
@@ -55,9 +55,9 @@
</distributionManagement>
<properties>
- <maven.version>3.1.1</maven.version>
<javaVersion>7</javaVersion>
- <aether.version>0.9.0.M2</aether.version>
+ <maven.version>3.1.1</maven.version>
+ <resolver.version>1.6.2</resolver.version>
Review comment:
I'm not sure about minimal resolver version here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas commented on a change in pull request #17: Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623622953
##########
File path: pom.xml
##########
@@ -98,59 +98,45 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.apache.maven</groupId>
- <artifactId>maven-plugin-api</artifactId>
- <version>${maven.version}</version>
- </dependency>
+
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.6</version>
</dependency>
- <dependency>
- <groupId>org.eclipse.aether</groupId>
- <artifactId>aether-api</artifactId>
- <version>${aether.version}</version>
- </dependency>
- <dependency>
- <groupId>org.eclipse.aether</groupId>
- <artifactId>aether-util</artifactId>
- <version>${aether.version}</version>
- </dependency>
- <dependency>
- <groupId>org.eclipse.sisu</groupId>
- <artifactId>org.eclipse.sisu.plexus</artifactId>
- <version>0.0.0.M5</version>
- </dependency>
+
+
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.2</version>
+ <version>${resolver.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-util</artifactId>
- <version>1.4.2</version>
+ <version>${resolver.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
- <version>3.3.3</version>
+ <version>3.3.5-SNAPSHOT</version>
Review comment:
Sure, just FTR this PR depends on https://github.com/apache/maven-shared-utils/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] elharo commented on a change in pull request #17: Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#discussion_r623375282
##########
File path: pom.xml
##########
@@ -98,59 +98,45 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${maven.version}</version>
+ <scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.apache.maven</groupId>
- <artifactId>maven-plugin-api</artifactId>
- <version>${maven.version}</version>
- </dependency>
+
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.6</version>
</dependency>
- <dependency>
- <groupId>org.eclipse.aether</groupId>
- <artifactId>aether-api</artifactId>
- <version>${aether.version}</version>
- </dependency>
- <dependency>
- <groupId>org.eclipse.aether</groupId>
- <artifactId>aether-util</artifactId>
- <version>${aether.version}</version>
- </dependency>
- <dependency>
- <groupId>org.eclipse.sisu</groupId>
- <artifactId>org.eclipse.sisu.plexus</artifactId>
- <version>0.0.0.M5</version>
- </dependency>
+
+
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
- <version>1.4.2</version>
+ <version>${resolver.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-util</artifactId>
- <version>1.4.2</version>
+ <version>${resolver.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
- <version>3.3.3</version>
+ <version>3.3.5-SNAPSHOT</version>
Review comment:
no dependencies on snapshot versions please
##########
File path: src/main/java/org/apache/maven/shared/artifact/filter/ScopeArtifactFilter.java
##########
@@ -25,7 +25,7 @@
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.DefaultArtifact;
import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
-import org.codehaus.plexus.logging.Logger;
+import org.slf4j.Logger;
Review comment:
can this change be separated into its own PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-common-artifact-filters] cstamas edited a comment on pull request #17: Sanitize dependencies
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #17:
URL: https://github.com/apache/maven-common-artifact-filters/pull/17#issuecomment-829442072
Setting maven-* artifacts to provided may affect consumers, so I may revert that change. Still, the presence of maven-plugin-api _assumes_ this artifact is consumed *only by plugins*? As in that case, we can assume plugin do depend on maven-plugin-api, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org