You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2012/07/18 19:35:35 UTC

[jira] [Created] (LOGGING-146) LogFactory.nullClassLoaderFactory is not properly synchronized

Sebb created LOGGING-146:
----------------------------

             Summary: LogFactory.nullClassLoaderFactory is not properly synchronized
                 Key: LOGGING-146
                 URL: https://issues.apache.org/jira/browse/LOGGING-146
             Project: Commons Logging
          Issue Type: Bug
    Affects Versions: 1.1.1
            Reporter: Sebb


Not all accesses to the protected static mutable field LogFactory.nullClassLoaderFactory are synch. using the same lock.

This is necessary to ensure safe publication of mutable fields.

As far as I can tell, the field is only required because a Hashtable cannot hold a null key. So it's not clear why the field is protected rather than private.

Also, it ought to be possible to replace the field with a dummy key object which can then be used in the Hashtable. That would simplify the code.
However, any subclasses that relied on the field contents might break.

If LogFactory is not intended to be part of the public API, then the field could be replaced by the dummy key approach.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira