You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Alexander Shraer (Created) (JIRA)" <ji...@apache.org> on 2011/11/09 06:31:51 UTC

[jira] [Created] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Remove unused readyToStart from Leader.java
-------------------------------------------

                 Key: ZOOKEEPER-1293
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
             Project: ZooKeeper
          Issue Type: Bug
          Components: server, tests
            Reporter: Alexander Shraer
            Assignee: Alexander Shraer
            Priority: Trivial
             Fix For: 3.5.0


After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177809#comment-13177809 ] 

Alexander Shraer commented on ZOOKEEPER-1293:
---------------------------------------------

by "better" I mean that the test is now more conservative
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shraer updated ZOOKEEPER-1293:
----------------------------------------

    Attachment: ZOOKEEPER-1293-ver2.patch
    
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177563#comment-13177563 ] 

Hadoop QA commented on ZOOKEEPER-1293:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503020/ZOOKEEPER-1293.patch
  against trunk revision 1225352.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/871//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/871//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/871//console

This message is automatically generated.
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177815#comment-13177815 ] 

Patrick Hunt commented on ZOOKEEPER-1293:
-----------------------------------------

Hi Alexander, yes, I get that. My point though was that readyToStart was volatile, while cnxAcceptor is not. Leader is setting cnxAcceptor just prior to setting readyToStart.

My concern is that cnxAcceptor will be null from the view of any other thread than the leader, given there is no longer any explicit barrier. Is this not correct?
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177806#comment-13177806 ] 

Alexander Shraer commented on ZOOKEEPER-1293:
---------------------------------------------

Hi Patrick, 

readyToStart was used in waitForEpochAck to check that the leader passed a certain point in the code (right before getEpochToPropose), and this check was not sufficient because it doesn't mean that the leader reached the getEpochToPropose or the waitForEpochAck barrier. ZK-1194 fixed this by explicitly checking that the leader reached the right barrier, so it no longer checks readyToStart. 

The only place where readyToStart is still used is in Zab1_0Test.java, where it is read to check that Leader.lead() passed cnxAcceptor.start(). As far as I understand, checking that leader.cnxAcceptor.isAlive() achieves the same (it might actually be better if cnxAcceptor.start() doesn't atomically make cnxAcceptor alive).

Happy New Year!
Alex
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shraer updated ZOOKEEPER-1293:
----------------------------------------

    Attachment: ZOOKEEPER-1293-ver2.patch
    
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181504#comment-13181504 ] 

Alexander Shraer commented on ZOOKEEPER-1293:
---------------------------------------------

thanks Patrick!
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-1293:
------------------------------------

    Issue Type: Improvement  (was: Bug)
    
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178125#comment-13178125 ] 

Hadoop QA commented on ZOOKEEPER-1293:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12509002/ZOOKEEPER-1293-ver2.patch
  against trunk revision 1225927.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/873//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/873//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/873//console

This message is automatically generated.
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177837#comment-13177837 ] 

Alexander Shraer commented on ZOOKEEPER-1293:
---------------------------------------------

I see. I agree that this creates a race on cnxAcceptor (although in practice I don't think this is harmful in this case since its used just to check whether to proceed or invoke another Thread.sleep(20)). 

We could just make cnxAcceptor volatile ?
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181755#comment-13181755 ] 

Patrick Hunt commented on ZOOKEEPER-1293:
-----------------------------------------

No thanks necessary. Thank you for contributing. Regards.
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177840#comment-13177840 ] 

Patrick Hunt commented on ZOOKEEPER-1293:
-----------------------------------------

Perhaps this would be a good place/time to refactor the code a bit, exposing a method from Leader rather than accessing fields of Leader directly? You could verify the synchronization as part of the fix. (unfortunately I didn't have time to look at it in more depth myself).
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shraer updated ZOOKEEPER-1293:
----------------------------------------

    Attachment: ZOOKEEPER-1293.patch
    
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177838#comment-13177838 ] 

Alexander Shraer commented on ZOOKEEPER-1293:
---------------------------------------------

wrt to ZK-1194 I don't believe there was a bug introduced since we use synchronized for connectingFollowers and electingFollowers 
                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1293) Remove unused readyToStart from Leader.java

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181235#comment-13181235 ] 

Hudson commented on ZOOKEEPER-1293:
-----------------------------------

Integrated in ZooKeeper-trunk #1419 (See [https://builds.apache.org/job/ZooKeeper-trunk/1419/])
    ZOOKEEPER-1293. Remove unused readyToStart from Leader.java (Alex Shraer via phunt)

phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227927
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java

                
> Remove unused readyToStart from Leader.java
> -------------------------------------------
>
>                 Key: ZOOKEEPER-1293
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1293
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server, tests
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293-ver2.patch, ZOOKEEPER-1293.patch
>
>
> After ZOOKEEPER-1194 readyToStart is no longer used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira