You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/06/14 12:47:43 UTC

[GitHub] [calcite] yinchuanwang commented on a change in pull request #2434: [CALCITE-4645] In Elasticsearch adapter, translate a range predicate to a range query(Jacky Yin)

yinchuanwang commented on a change in pull request #2434:
URL: https://github.com/apache/calcite/pull/2434#discussion_r650915318



##########
File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/PredicateAnalyzer.java
##########
@@ -200,22 +201,6 @@ private static boolean supportedRexCall(RexCall call) {
       }
     }
 
-    /**

Review comment:
       Ok. I kept the the explanation about the 3 subtypes of Sarg in the comments.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org