You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/21 11:44:14 UTC

[GitHub] [maven-resources-plugin] elharo opened a new pull request #6: future proof method that is marked for incompatible change

elharo opened a new pull request #6:
URL: https://github.com/apache/maven-resources-plugin/pull/6


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-resources-plugin] dennisl commented on pull request #6: future proof method that is marked for incompatible change

Posted by GitBox <gi...@apache.org>.
dennisl commented on pull request #6:
URL: https://github.com/apache/maven-resources-plugin/pull/6#issuecomment-661907185


   In my experience it is very useful. When moving a project from being built locally by developers to a CI solution, developers are often surprised when they don't get the same results there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-resources-plugin] elharo commented on pull request #6: future proof method that is marked for incompatible change

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #6:
URL: https://github.com/apache/maven-resources-plugin/pull/6#issuecomment-661902051


   Is it useful though? The relevant detail is that the platform default is being used. The point is that whatever value that is, and which we would print here, is not reliable or consistent. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-resources-plugin] dennisl commented on pull request #6: future proof method that is marked for incompatible change

Posted by GitBox <gi...@apache.org>.
dennisl commented on pull request #6:
URL: https://github.com/apache/maven-resources-plugin/pull/6#issuecomment-661948840


   If their build is failing, then knowing the encoding that was used gives
   them a hint about what not to use.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-resources-plugin] elharo commented on pull request #6: future proof method that is marked for incompatible change

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #6:
URL: https://github.com/apache/maven-resources-plugin/pull/6#issuecomment-661910389


   Yes, and when that happens they should sit down and figure out which encoding they should use (usually UTF-8). They should not simply copy and paste whichever encoding they happened to be using by accident like they're writing a characterization test to mimic the idiosyncratic behavior of their development box. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org