[GitHub] [iceberg] abmo-x commented on pull request #5311: S3OutputStream - failure to close should persist on subsequent close calls

[GitBox <gi...@apache.org>]

abmo-x commented on PR #5311:
URL: https://github.com/apache/iceberg/pull/5311#issuecomment-1202030169

   > @abmo-x Based on the description, it seems to me that application shouldn't have caught and swallowed all exceptions in the process function. I know it tries to catch "bad" record and route to a dead-letter table. It probably should just catch and handle the serialization specific exceptions.
   
   Yes, the application code will be updated to handle exceptions correctly as well. As there are [other cases](https://github.com/apache/iceberg/pull/1749) where the S3 output stream can be still used after its closed I think this defensive code helps enforce bad data files are not added to metadata. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org