You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/07/03 18:24:45 UTC
[GitHub] [buildstream-plugins] abderrahim opened a new pull request, #15: Multiple fixes to the cargo plugin
abderrahim opened a new pull request, #15:
URL: https://github.com/apache/buildstream-plugins/pull/15
This is a collection of fixes to the cargo plugin to be usable by gnome-build-meta. The first one is original, the rest are ports of the following MRs from bst-external. Not sure about the licensing, we might need to ask permission.
https://gitlab.com/BuildStream/bst-external/-/merge_requests/152 by Jonathan Maw
https://gitlab.com/BuildStream/bst-external/-/merge_requests/157 by myself
https://gitlab.com/BuildStream/bst-external/-/merge_requests/182 by @nanonyme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan merged pull request #15: Multiple fixes to the cargo plugin
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #15:
URL: https://github.com/apache/buildstream-plugins/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #15: Multiple fixes to the cargo plugin
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #15:
URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173484863
> https://gitlab.com/BuildStream/bst-external/-/merge_requests/152 by Jonathan Maw
@jonathanmaw's merge request is covered by Codethink's CCLA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #15: Multiple fixes to the cargo plugin
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #15:
URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173503077
I think this branch is OK to land.
I'd note that the commit which avoids downloading crates at track time for which we already have a `sha` is a discrepancy in behavior when compared with sources like `tar`, which are expected to derive the `sha` from the remote unconditionally (and print a warning in the case that an existing `sha` is *changed*).
Cargo is sufficiently different, inasmuch as it may make sense to *track* the cargo source even when some of the `sha`s are already known locally but not all of them are known.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] abderrahim commented on pull request #15: Multiple fixes to the cargo plugin
Posted by GitBox <gi...@apache.org>.
abderrahim commented on PR #15:
URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173542005
> I'd note that the commit which avoids downloading crates at track time for which we already have a `sha` is a discrepancy in behavior when compared with sources like `tar`, which are expected to derive the `sha` from the remote unconditionally (and print a warning in the case that an existing `sha` is _changed_).
Maybe I'll let your past self answer the question: https://gitlab.com/BuildStream/bst-external/-/merge_requests/157#note_836698782
Either way, we don't use the sha that is already tracked (or at least, that's not the intent) but rather the sha that is available in the Cargo.lock file that we're using. To put it differently, we're tracking the Cargo.lock, not the remot..
This is not exactly correct for tar either. tar has a shortcut that makes it not download unconditionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #15: Multiple fixes to the cargo plugin
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #15:
URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173164691
I'm definitely okay with relicensing of my parts at any rate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #15: Multiple fixes to the cargo plugin
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #15:
URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173506424
@gtristan the problem is with g-b-m cargo tracking was routinely failing when cargo upstream throttled downloads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #15: Multiple fixes to the cargo plugin
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #15:
URL: https://github.com/apache/buildstream-plugins/pull/15#issuecomment-1173628745
> Maybe I'll let your past self answer the question: https://gitlab.com/BuildStream/bst-external/-/merge_requests/157#note_836698782
Gotcha.
> This is not exactly correct for tar either. tar has a shortcut that makes it not download unconditionally.
At fetch time we use the etag feature to avoid already downloaded tarballs. At track time the presumption is that we must determine what the `sha` is, so we must unconditionally download it to determine the sha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org