You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/12/13 08:53:48 UTC

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #410: Improved: VIEW permissions FinAccount mutations (OFBIZ-12451)

PierreSmits opened a new pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410


   Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Financial Account mutations screen  sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
   See (test with):
   https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING
   https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw
   
   Modified:
   - FinAccountScreens.xml: work with permissions, added ref to mutations template for user with VIEW permission
   Added:
   - Mutations.ftl template


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #410: Improved: VIEW permissions FinAccount mutations (OFBIZ-12451)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux merged pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #410: Improved: VIEW permissions FinAccount mutations (OFBIZ-12451)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410#issuecomment-1007171525


   Hi Jacques,
   
   It is true that the underlying entity used to display the line items has more elements than is being displayed with the change. This is controlled by the DepositWithdrawPayments.groovy script, which pulls data from PaymentAndTypePartyNameView. 
   
   Neither Fin Account Name, nor From Date are part of that dataset. 
   
   While the script potentially could provide more data elements from the source, the original implementation doesn't show that (see with login = admin). So that has been followed here. We can leave that at the hands of downstream implementers.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #410: Improved: VIEW permissions FinAccount mutations (OFBIZ-12451)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410#issuecomment-1006748343


   Pierre,
   
   Why are some elements not present in the view only?
   Fin Account Name
   From Date
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #410: Improved: VIEW permissions FinAccount mutations (OFBIZ-12451)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux merged pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #410: Improved: VIEW permissions FinAccount mutations (OFBIZ-12451)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410#issuecomment-1007171525


   Hi Jacques,
   
   It is true that the underlying entity used to display the line items has more elements than is being displayed with the change. This is controlled by the DepositWithdrawPayments.groovy script, which pulls data from PaymentAndTypePartyNameView. 
   
   Neither Fin Account Name, nor From Date are part of that dataset. 
   
   While the script potentially could provide more data elements from the source, the original implementation doesn't show that (see with login = admin). So that has been followed here. We can leave that at the hands of downstream implementers.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #410: Improved: VIEW permissions FinAccount mutations (OFBIZ-12451)

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410#issuecomment-992241753


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=410&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=410) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=410&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=410&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org