[GitHub] [apisix-dashboard] membphis commented on a change in pull request #619: feat: added e2e test for Login page

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #619:
URL: https://github.com/apache/apisix-dashboard/pull/619#discussion_r515877863



##########
File path: docs/develop.md
##########
@@ -35,6 +35,8 @@ $ yarn install
 ```sh
 $ yarn start
 ```
+### wirte e2e test case

Review comment:
       md style: need a blank line before and after the title

##########
File path: frontend/src/e2e/README.md
##########
@@ -0,0 +1,41 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+### Writing test cases
+
+1. Install dependencies then run in development mode
+
+```sh
+$ yarn install && yarn start

Review comment:
       here is an example of APISIX, you can take a look: https://github.com/apache/apisix/blob/master/Makefile#L70




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org