[GitHub] [spark] maropu commented on a change in pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should respect propagateNull

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #28681:
URL: https://github.com/apache/spark/pull/28681#discussion_r432926563



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -383,15 +383,26 @@ case class Invoke(
       """
     }
 
+    val evalFunc = if (propagateNull) {
+      s"""
+        ${ev.isNull} = $resultIsNull;
+        if (!${ev.isNull}) {
+          $evaluate
+        }
+      """
+    } else {
+      s"""
+        ${ev.isNull} = false;
+        $evaluate
+      """
+    }

Review comment:
       Ur, I missed that and you're right. I'll revert this. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org