[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534997#comment-16534997 ] 

ASF GitHub Bot commented on TINKERPOP-967:
------------------------------------------

Github user GCHQResearcher1337 commented on the issue:

    https://github.com/apache/tinkerpop/pull/876
  
    I've now added support for named loops - described in https://issues.apache.org/jira/browse/TINKERPOP-967, however I have not introduced a new `times()` step. 
    
    I think a new `times()` step would be of marginal benefit and could be confusing - currently `times()` is a step modulator on `repeat()`. 
    
    I've also changed to explicit loop stack initialisation rather than setting it up on the increment.  Setting up the stack/counter on the increment creates a problem in the nested context - when the inner `loops()` is called it incorrectly returns the top counter from the stack. 


> Support nested-repeat() structures
> ----------------------------------
>
>                 Key: TINKERPOP-967
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-967
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>            Priority: Major
>
> All the internal plumbing is staged for this to happen, we just haven't gone all the way. In short, a {{NESTED_LOOP}} traverser has an internal {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two. The {{it.loops()}} checks of the internal repeat will always check the top of the stack and when its done repeating will delete its counter off the top of the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that naming the loop stack will be a super rare case as most people will just assume standard nested looping semantics with a push/pop stack.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)