[GitHub] [ignite-3] AMashenkov commented on a change in pull request #498: IGNITE-15870 Calcite. Replace usages of Lists and Sets of int to IntList\IntSet

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #498:
URL: https://github.com/apache/ignite-3/pull/498#discussion_r766621771



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdCollation.java
##########
@@ -318,7 +319,7 @@ private IgniteMdCollation() {
             if (project.e instanceof RexInputRef) {
                 targets.compute(((RexSlot) project.e).getIndex(), (k, v) -> {
                             if (v == null) {
-                                return new ArrayList<>(Collections.singleton(project.i));
+                                return new IntArrayList(Collections.singleton(project.i));

Review comment:
       The main goal of using IntList (avoid boxing/unboxing) is still not achieved. 
   ```suggestion
                                   return new IntArrayList(project.i);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org