You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cantecim <gi...@git.apache.org> on 2015/07/26 20:17:26 UTC
[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...
GitHub user cantecim opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/29
Solved toLowerCase issue with Locale.US
There was an issue with toLowerCase method which causes if conditions to fail because of user locale
For example: In turkish locale lower case form of WIFI is wıfı. Which means "wifi" == "wıfı" condition is never true. Using US Locale with toLowerCase methods solves the problem as you can see
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cantecim/cordova-plugin-network-information master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit c40e579c5aa4e77a4695040b44ce3aa427429a1e
Author: Can Tecim <ca...@gmail.com>
Date: 2015-07-26T18:11:52Z
Solved toLowerCase issue with Locale.US
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...
Posted by SidFerreira <gi...@git.apache.org>.
Github user SidFerreira commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125732348
Why not make the toLowerCase on the line #236 and saving all the conversion and tests on the other lines?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125734549
Send a pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org