[GitHub] [ozone] adoroszlai commented on a change in pull request #2426: HDDS-5457. services.s3g.environment.OZONE-SITE.XML_ozone.om.enable.filesystem.paths must be a string, number or null

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2426:
URL: https://github.com/apache/ozone/pull/2426#discussion_r671802306



##########
File path: hadoop-ozone/dist/src/main/compose/ozone/docker-compose.yaml
##########
@@ -28,7 +28,7 @@ x-common-config:
 x-layout_version:
   &metadata_layout
   OZONE-SITE.XML_ozone.om.metadata.layout: ${OZONE_OM_METADATA_LAYOUT:-SIMPLE}
-  OZONE-SITE.XML_ozone.om.enable.filesystem.paths: ${OZONE_OM_ENABLE_FILESYSTEM_PATHS:-false}
+  OZONE-SITE.XML_ozone.om.enable.filesystem.paths: ${OZONE_OM_ENABLE_FILESYSTEM_PATHS:-'false'}

Review comment:
       We also need to escape the value of `OZONE_OM_ENABLE_FILESYSTEM_PATHS` if defined.
   
   ```suggestion
     OZONE-SITE.XML_ozone.om.enable.filesystem.paths: "${OZONE_OM_ENABLE_FILESYSTEM_PATHS:-false}"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org