[GitHub] [spark] srowen commented on a change in pull request #35566: [SPARK-38249][CORE][GRAPHX] Cleanup unused private methods/fields

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #35566:
URL: https://github.com/apache/spark/pull/35566#discussion_r809971732



##########
File path: core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolMessage.scala
##########
@@ -46,9 +46,6 @@ private[rest] abstract class SubmitRestProtocolMessage {
   val action: String = messageType
   var message: String = null
 
-  // For JSON deserialization
-  private def setAction(a: String): Unit = { }

Review comment:
       I'm worried that the JSON deserializer needs this, per comment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org