You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/02/11 09:09:13 UTC

[GitHub] [rocketmq] cserwen commented on issue #3507: [POP] The endTime for popReviveService is bigger than actual

cserwen commented on issue #3507:
URL: https://github.com/apache/rocketmq/issues/3507#issuecomment-1036003012


   > IMO, using deliverTime as endTime has no effect to pop function, the blue message that is still in SCHEDULE_XXX topic will be delivered to retry topic in advance. The key problem is using deliverTime or storeTime as the end time point using for judging timeout.
   
   @lizhiboo I think this works, if this endtime is true, the judgment on recovery here will take effect,
   https://github.com/apache/rocketmq/blob/631405e2fba8849f9bce5e275825aa16944b8097/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java#L344


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org