You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2010/09/30 20:00:35 UTC

[jira] Created: (HBASE-3056) Fix ordering in ZKWatcher constructor to prevent weird race condition

Fix ordering in ZKWatcher constructor to prevent weird race condition
---------------------------------------------------------------------

                 Key: HBASE-3056
                 URL: https://issues.apache.org/jira/browse/HBASE-3056
             Project: HBase
          Issue Type: Bug
          Components: zookeeper
    Affects Versions: 0.90.0
            Reporter: Jonathan Gray
            Assignee: Jonathan Gray
             Fix For: 0.90.0


A small race condition in ZKWatcher leads to an NPE:

{noformat}
2010-09-30 10:56:36,028 INFO  [Thread-217] zookeeper.ZKUtil(93): hconnection opening connection to ZooKeeper with quorum (localhost:21815)
2010-09-30 10:56:36,036 DEBUG [Thread-217-EventThread] zookeeper.ZooKeeperWatcher(184): hconnection Received ZooKeeper Event, type=None, state=SyncConnected, path=null
2010-09-30 10:56:36,036 ERROR [Thread-217-EventThread] zookeeper.ClientCnxn$EventThread(490): Error while calling watcher 
java.lang.NullPointerException
	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.connectionEvent(ZooKeeperWatcher.java:243)
	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:193)
	at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:488)
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-3056) Fix ordering in ZKWatcher constructor to prevent weird race condition

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray resolved HBASE-3056.
----------------------------------

    Hadoop Flags: [Reviewed]
      Resolution: Fixed

Committed.  Thanks for review stack.

> Fix ordering in ZKWatcher constructor to prevent weird race condition
> ---------------------------------------------------------------------
>
>                 Key: HBASE-3056
>                 URL: https://issues.apache.org/jira/browse/HBASE-3056
>             Project: HBase
>          Issue Type: Bug
>          Components: zookeeper
>    Affects Versions: 0.90.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.90.0
>
>         Attachments: HBASE-3056-v1.patch
>
>
> A small race condition in ZKWatcher leads to an NPE:
> {noformat}
> 2010-09-30 10:56:36,028 INFO  [Thread-217] zookeeper.ZKUtil(93): hconnection opening connection to ZooKeeper with quorum (localhost:21815)
> 2010-09-30 10:56:36,036 DEBUG [Thread-217-EventThread] zookeeper.ZooKeeperWatcher(184): hconnection Received ZooKeeper Event, type=None, state=SyncConnected, path=null
> 2010-09-30 10:56:36,036 ERROR [Thread-217-EventThread] zookeeper.ClientCnxn$EventThread(490): Error while calling watcher 
> java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.connectionEvent(ZooKeeperWatcher.java:243)
> 	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:193)
> 	at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:488)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3056) Fix ordering in ZKWatcher constructor to prevent weird race condition

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916586#action_12916586 ] 

stack commented on HBASE-3056:
------------------------------

+1

> Fix ordering in ZKWatcher constructor to prevent weird race condition
> ---------------------------------------------------------------------
>
>                 Key: HBASE-3056
>                 URL: https://issues.apache.org/jira/browse/HBASE-3056
>             Project: HBase
>          Issue Type: Bug
>          Components: zookeeper
>    Affects Versions: 0.90.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.90.0
>
>         Attachments: HBASE-3056-v1.patch
>
>
> A small race condition in ZKWatcher leads to an NPE:
> {noformat}
> 2010-09-30 10:56:36,028 INFO  [Thread-217] zookeeper.ZKUtil(93): hconnection opening connection to ZooKeeper with quorum (localhost:21815)
> 2010-09-30 10:56:36,036 DEBUG [Thread-217-EventThread] zookeeper.ZooKeeperWatcher(184): hconnection Received ZooKeeper Event, type=None, state=SyncConnected, path=null
> 2010-09-30 10:56:36,036 ERROR [Thread-217-EventThread] zookeeper.ClientCnxn$EventThread(490): Error while calling watcher 
> java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.connectionEvent(ZooKeeperWatcher.java:243)
> 	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:193)
> 	at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:488)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3056) Fix ordering in ZKWatcher constructor to prevent weird race condition

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-3056:
---------------------------------

    Attachment: HBASE-3056-v1.patch

Easy fix.  Quick review anyone?

> Fix ordering in ZKWatcher constructor to prevent weird race condition
> ---------------------------------------------------------------------
>
>                 Key: HBASE-3056
>                 URL: https://issues.apache.org/jira/browse/HBASE-3056
>             Project: HBase
>          Issue Type: Bug
>          Components: zookeeper
>    Affects Versions: 0.90.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.90.0
>
>         Attachments: HBASE-3056-v1.patch
>
>
> A small race condition in ZKWatcher leads to an NPE:
> {noformat}
> 2010-09-30 10:56:36,028 INFO  [Thread-217] zookeeper.ZKUtil(93): hconnection opening connection to ZooKeeper with quorum (localhost:21815)
> 2010-09-30 10:56:36,036 DEBUG [Thread-217-EventThread] zookeeper.ZooKeeperWatcher(184): hconnection Received ZooKeeper Event, type=None, state=SyncConnected, path=null
> 2010-09-30 10:56:36,036 ERROR [Thread-217-EventThread] zookeeper.ClientCnxn$EventThread(490): Error while calling watcher 
> java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.connectionEvent(ZooKeeperWatcher.java:243)
> 	at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:193)
> 	at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:488)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.