You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Diana Arroyo <da...@us.ibm.com> on 2015/12/18 21:25:50 UTC
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 8:25 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Cleaned up FindCurl based on my findings and comments of Alex's review regarding line number 58.
Summary (updated)
-----------------
CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
Diff: https://reviews.apache.org/r/41108/diff/
Testing (updated)
-------
Tested on Ubuntu and OSX.
Tested if and else path of new logic added to FindCurl.cmake.
Thanks,
Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review119139
-----------------------------------------------------------
Bad patch!
Reviews applied: [41096, 41185, 41108]
Failed command: ./support/apply-review.sh -n -r 41108
Error:
2016-02-13 06:33:04 URL:https://reviews.apache.org/r/41108/diff/raw/ [4052/4052] -> "41108.patch" [1]
error: patch failed: src/slave/cmake/FindCurl.cmake:31
error: src/slave/cmake/FindCurl.cmake: patch does not apply
error: patch failed: src/slave/cmake/SlaveConfigure.cmake:51
error: src/slave/cmake/SlaveConfigure.cmake: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/11424/console
- Mesos ReviewBot
On Feb. 13, 2016, 3:53 a.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2016, 3:53 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/FindCurl.cmake PRE-CREATION
> src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
>
> Diff: https://reviews.apache.org/r/41108/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
> Tested if and else path of new logic added to FindCurl.cmake.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/
-----------------------------------------------------------
(Updated Feb. 13, 2016, 3:53 a.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Rebase per Alex's request.
Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/cmake/FindCurl.cmake PRE-CREATION
src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
Diff: https://reviews.apache.org/r/41108/diff/
Testing
-------
Tested on Ubuntu and OSX.
Tested if and else path of new logic added to FindCurl.cmake.
Thanks,
Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review114288
-----------------------------------------------------------
Bad patch!
Reviews applied: [41096, 41185, 41108]
Failed command: ./support/apply-review.sh -n -r 41108
Error:
2016-01-13 21:28:11 URL:https://reviews.apache.org/r/41108/diff/raw/ [5294/5294] -> "41108.patch" [1]
No files to lint
Error: Commit message summary (the first line) must not exceed 72 characters.
- Mesos ReviewBot
On Jan. 13, 2016, 6:31 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 6:31 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/FindCurl.cmake df81fd538b06bf0c3e842a502bd5ef4083d897b5
> src/slave/cmake/SlaveConfigure.cmake cf378a27297474b2a9f338e0c832612370f7302a
>
> Diff: https://reviews.apache.org/r/41108/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
> Tested if and else path of new logic added to FindCurl.cmake.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 6:31 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/cmake/FindCurl.cmake df81fd538b06bf0c3e842a502bd5ef4083d897b5
src/slave/cmake/SlaveConfigure.cmake cf378a27297474b2a9f338e0c832612370f7302a
Diff: https://reviews.apache.org/r/41108/diff/
Testing
-------
Tested on Ubuntu and OSX.
Tested if and else path of new logic added to FindCurl.cmake.
Thanks,
Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 6:09 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/cmake/FindCurl.cmake PRE-CREATION
src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
Diff: https://reviews.apache.org/r/41108/diff/
Testing
-------
Tested on Ubuntu and OSX.
Tested if and else path of new logic added to FindCurl.cmake.
Thanks,
Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Diana Arroyo <da...@us.ibm.com>.
> On Jan. 8, 2016, 4:43 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [41096, 41185, 41108]
> >
> > Failed command: ./support/apply-review.sh -n -r 41108
> >
> > Error:
> > 2016-01-08 16:43:43 URL:https://reviews.apache.org/r/41108/diff/raw/ [4052/4052] -> "41108.patch" [1]
> > error: patch failed: src/slave/cmake/FindCurl.cmake:31
> > error: src/slave/cmake/FindCurl.cmake: patch does not apply
>
> Alex Clemmer wrote:
> It looks like you need to update your master and rebase this commit to come after the last commit on the master branch? Ping me if you need help with this.
Please see: https://reviews.apache.org/r/42250/
- Diana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review113487
-----------------------------------------------------------
On Jan. 8, 2016, 3:29 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 3:29 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/FindCurl.cmake PRE-CREATION
> src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
>
> Diff: https://reviews.apache.org/r/41108/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
> Tested if and else path of new logic added to FindCurl.cmake.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Jan. 8, 2016, 4:43 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [41096, 41185, 41108]
> >
> > Failed command: ./support/apply-review.sh -n -r 41108
> >
> > Error:
> > 2016-01-08 16:43:43 URL:https://reviews.apache.org/r/41108/diff/raw/ [4052/4052] -> "41108.patch" [1]
> > error: patch failed: src/slave/cmake/FindCurl.cmake:31
> > error: src/slave/cmake/FindCurl.cmake: patch does not apply
It looks like you need to update your master and rebase this commit to come after the last commit on the master branch? Ping me if you need help with this.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review113487
-----------------------------------------------------------
On Jan. 8, 2016, 3:29 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 3:29 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/FindCurl.cmake PRE-CREATION
> src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
>
> Diff: https://reviews.apache.org/r/41108/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
> Tested if and else path of new logic added to FindCurl.cmake.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review113487
-----------------------------------------------------------
Bad patch!
Reviews applied: [41096, 41185, 41108]
Failed command: ./support/apply-review.sh -n -r 41108
Error:
2016-01-08 16:43:43 URL:https://reviews.apache.org/r/41108/diff/raw/ [4052/4052] -> "41108.patch" [1]
error: patch failed: src/slave/cmake/FindCurl.cmake:31
error: src/slave/cmake/FindCurl.cmake: patch does not apply
- Mesos ReviewBot
On Jan. 8, 2016, 3:29 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 3:29 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/FindCurl.cmake PRE-CREATION
> src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
>
> Diff: https://reviews.apache.org/r/41108/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
> Tested if and else path of new logic added to FindCurl.cmake.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 3:29 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Actually included the code changes that reflect the comments this time.
Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/cmake/FindCurl.cmake PRE-CREATION
src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
Diff: https://reviews.apache.org/r/41108/diff/
Testing
-------
Tested on Ubuntu and OSX.
Tested if and else path of new logic added to FindCurl.cmake.
Thanks,
Diana Arroyo
Re: Review Request 41108: CMake: Add sasl and dl link flags,
add curl link library and add protobuf library directory.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review111302
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40951, 41090, 41108]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 18, 2015, 8:25 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 8:25 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b
>
> Diff: https://reviews.apache.org/r/41108/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
> Tested if and else path of new logic added to FindCurl.cmake.
>
>
> Thanks,
>
> Diana Arroyo
>
>