You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/22 07:51:07 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #20360: Add more unit tests for the class of `AutoCommitUtils`

FlyingZC opened a new issue, #20360:
URL: https://github.com/apache/shardingsphere/issues/20360

   Hi community,
   This issue is for [#20305](https://github.com/apache/shardingsphere/issues/20305)
   
   # Aim
   Add more unit tests for the class of `org.apache.shardingsphere.transaction.utils.AutoCommitUtils`.
   
   # Basic Qualifications
   - Java
   - Maven
   - Transaction
   
   # Detail
   Maybe you can mock the sqlStatement like `new MySQLSelectStatement()`,`new MySQLAlterTableStatement()`... and assert the result of `needOpenTransaction` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] abhinav-koppula commented on issue #20360: Add more unit tests for the class of `AutoCommitUtils`

Posted by GitBox <gi...@apache.org>.
abhinav-koppula commented on issue #20360:
URL: https://github.com/apache/shardingsphere/issues/20360#issuecomment-1265527604

   @strongduanmu - I have created a PR - https://github.com/apache/shardingsphere/pull/21332.
   Can you please review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] FlyingZC commented on issue #20360: Add more unit tests for the class of `AutoCommitUtils`

Posted by GitBox <gi...@apache.org>.
FlyingZC commented on issue #20360:
URL: https://github.com/apache/shardingsphere/issues/20360#issuecomment-1221989737

   You can check the test coverage on this page: https://app.codecov.io/gh/apache/shardingsphere
   <img width="1160" alt="image" src="https://user-images.githubusercontent.com/19788130/185869583-9413aa1e-99eb-4932-9f5c-6f128402d8e3.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org