You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/20 07:10:59 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #368: Replace all CONFIG_NFILE_STREAMS with CONFIG_FILE_STREAM
xiaoxiang781216 opened a new pull request #368:
URL: https://github.com/apache/incubator-nuttx-apps/pull/368
## Summary
follow up the kernel side change: https://github.com/apache/incubator-nuttx/pull/1611
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] liuguo09 merged pull request #368: Replace all CONFIG_NFILE_STREAMS with CONFIG_FILE_STREAM
Posted by GitBox <gi...@apache.org>.
liuguo09 merged pull request #368:
URL: https://github.com/apache/incubator-nuttx-apps/pull/368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] liuguo09 merged pull request #368: Replace all CONFIG_NFILE_STREAMS with CONFIG_FILE_STREAM
Posted by GitBox <gi...@apache.org>.
liuguo09 merged pull request #368:
URL: https://github.com/apache/incubator-nuttx-apps/pull/368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ghn-certi commented on a change in pull request #368: Replace all CONFIG_NFILE_STREAMS with CONFIG_FILE_STREAM
Posted by GitBox <gi...@apache.org>.
ghn-certi commented on a change in pull request #368:
URL: https://github.com/apache/incubator-nuttx-apps/pull/368#discussion_r477246146
##########
File path: nshlib/README.md
##########
@@ -1599,7 +1599,7 @@ rptun | `CONFIG_RPTUN`
set | `CONFIG_NSH_VARS` || !`CONFIG_DISABLE_ENVIRON`
shutdown | `CONFIG_BOARDCTL_POWEROFF` || `CONFIG_BOARDCTL_RESET`
sleep | -
-source | `CONFIG_NFILE_STREAMS` > 0 && !`CONFIG_NSH_DISABLESCRIPT`
+source | `CONFIG_FILE_STREAM` > 0 && !`CONFIG_NSH_DISABLESCRIPT`
Review comment:
```suggestion
source | `CONFIG_FILE_STREAM` && !`CONFIG_NSH_DISABLESCRIPT`
```
Here the comparison to 0 does not make sense anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #368: Replace all CONFIG_NFILE_STREAMS with CONFIG_FILE_STREAM
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #368:
URL: https://github.com/apache/incubator-nuttx-apps/pull/368#discussion_r477401414
##########
File path: nshlib/README.md
##########
@@ -1599,7 +1599,7 @@ rptun | `CONFIG_RPTUN`
set | `CONFIG_NSH_VARS` || !`CONFIG_DISABLE_ENVIRON`
shutdown | `CONFIG_BOARDCTL_POWEROFF` || `CONFIG_BOARDCTL_RESET`
sleep | -
-source | `CONFIG_NFILE_STREAMS` > 0 && !`CONFIG_NSH_DISABLESCRIPT`
+source | `CONFIG_FILE_STREAM` > 0 && !`CONFIG_NSH_DISABLESCRIPT`
Review comment:
Done, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] liuguo09 merged pull request #368: Replace all CONFIG_NFILE_STREAMS with CONFIG_FILE_STREAM
Posted by GitBox <gi...@apache.org>.
liuguo09 merged pull request #368:
URL: https://github.com/apache/incubator-nuttx-apps/pull/368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] liuguo09 merged pull request #368: Replace all CONFIG_NFILE_STREAMS with CONFIG_FILE_STREAM
Posted by GitBox <gi...@apache.org>.
liuguo09 merged pull request #368:
URL: https://github.com/apache/incubator-nuttx-apps/pull/368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org