[jira] [Reopened] (FLINK-14481) Modify the Flink valid socket port check to 0 to 65535.

["Piotr Nowojski (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Piotr Nowojski reopened FLINK-14481:
------------------------------------
      Assignee:     (was: AT-Fieldless)

Thanks for rising this issue. Yes it wasn't fixed fully, so I'm reopening this. We should also deduplicate those range checks by introducing some utility function to avoid such problems in the future (I guess those multiple {{checkArguments}} were just copied pasted in the past).

> Modify the Flink valid socket port check to 0 to 65535.
> -------------------------------------------------------
>
>                 Key: FLINK-14481
>                 URL: https://issues.apache.org/jira/browse/FLINK-14481
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Network
>    Affects Versions: 1.9.1
>            Reporter: ming li
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In Flink, I found that Flink's socket port check is 'port >= 0 && port <= 65536.
> {code:java}
> checkArgument(serverPort >= 0 && serverPort <= 65536, "Invalid port number.");{code}
> But in the process of binding the port, the valid port is 0 to 65535(A port number of zero will let the System pick up anephemeral port in a bin operation). Although the 65536 port will fail due to the port out of range when actually binding, Flink has already done a valid range check on the port, which seems to be very confusing. Should we modify Flink's port check to 0 to 65535?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)