[GitHub] [beam] aimiebell commented on a change in pull request #13817: [Beam-11389] Implement LOGICAL_AND as CombineFn ZetaSQL

[GitBox <gi...@apache.org>]

aimiebell commented on a change in pull request #13817:
URL: https://github.com/apache/beam/pull/13817#discussion_r572623144



##########
File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
##########
@@ -4067,4 +4064,113 @@ public void testSimpleTableName() {
             Row.withSchema(singleField).addValues(15L).build());
     pipeline.run().waitUntilFinish(Duration.standardMinutes(PIPELINE_EXECUTION_WAITTIME_MINUTES));
   }
+
+  /** Tests for logical_and operation with different inputs. */
+  @RunWith(Parameterized.class)
+  public static class LogicalAndTests {
+
+    @Parameterized.Parameters
+    public static Collection<Object[]> inputData() {
+      Object[][] data =
+          new Object[][] {{false, false, false}, {true, true, true}, {true, false, false}};
+      return Arrays.asList(data);
+    }
+
+    @Parameterized.Parameter(0)

Review comment:
       I detect that this code is problematic. According to the [Bad practice (BAD_PRACTICE)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#bad-practice-bad-practice), [Nm: Method names should start with a lower case letter (NM_METHOD_NAMING_CONVENTION)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#nm-method-names-should-start-with-a-lower-case-letter-nm-method-naming-convention).
   Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org