You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/09 07:52:19 UTC
Review Request 56483: HiveView2.0: DB panel shows up on Query result
full screen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56483/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19931
https://issues.apache.org/jira/browse/AMBARI-19931
Repository: ambari
Description
-------
Minor JS issue
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4f73ef8
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8ee8e87
Diff: https://reviews.apache.org/r/56483/diff/
Testing
-------
manuualy tested
Thanks,
Pallav Kulshreshtha
Re: Review Request 56483: HiveView2.0: DB panel shows up on Query
result full screen
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
> On Feb. 9, 2017, 11:05 a.m., Nitiraj Rathore wrote:
> > contrib/views/hive20/src/main/resources/ui/app/services/query.js, line 83
> > <https://reviews.apache.org/r/56483/diff/2/?file=1628299#file1628299line83>
> >
> > can this be put into jobs service. Also it would be more usable if this returns job object in resolve. Also if error we should check for status "cancelled". This will happen if user cancels the job from hive view UI or yarn UI or otherwise cancels a running job.
There is already a function in jobs, removed extra function in query service.
- Pallav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56483/#review164891
-----------------------------------------------------------
On Feb. 11, 2017, 10:43 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56483/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 10:43 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19931
> https://issues.apache.org/jira/browse/AMBARI-19931
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Minor JS issue
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
> contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 2d6c5aa
>
> Diff: https://reviews.apache.org/r/56483/diff/
>
>
> Testing
> -------
>
> manuualy tested
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56483: HiveView2.0: DB panel shows up on Query
result full screen
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56483/#review164891
-----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/services/query.js (line 83)
<https://reviews.apache.org/r/56483/#comment236733>
can this be put into jobs service. Also it would be more usable if this returns job object in resolve. Also if error we should check for status "cancelled". This will happen if user cancels the job from hive view UI or yarn UI or otherwise cancels a running job.
- Nitiraj Rathore
On Feb. 9, 2017, 9:16 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56483/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 9:16 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19931
> https://issues.apache.org/jira/browse/AMBARI-19931
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Minor JS issue
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
> contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4f73ef8
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8ee8e87
>
> Diff: https://reviews.apache.org/r/56483/diff/
>
>
> Testing
> -------
>
> manuualy tested
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56483: HiveView2.0: DB panel shows up on Query
result full screen
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56483/#review165241
-----------------------------------------------------------
Ship it!
- Abhishek Kumar
On Feb. 11, 2017, 10:43 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56483/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 10:43 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19931
> https://issues.apache.org/jira/browse/AMBARI-19931
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Minor JS issue
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
> contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 2d6c5aa
>
> Diff: https://reviews.apache.org/r/56483/diff/
>
>
> Testing
> -------
>
> manuualy tested
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56483: HiveView2.0: DB panel shows up on Query
result full screen
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56483/
-----------------------------------------------------------
(Updated Feb. 11, 2017, 10:43 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19931
https://issues.apache.org/jira/browse/AMBARI-19931
Repository: ambari
Description
-------
Minor JS issue
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 2d6c5aa
Diff: https://reviews.apache.org/r/56483/diff/
Testing
-------
manuualy tested
Thanks,
Pallav Kulshreshtha
Re: Review Request 56483: HiveView2.0: DB panel shows up on Query
result full screen
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56483/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 9:16 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19931
https://issues.apache.org/jira/browse/AMBARI-19931
Repository: ambari
Description
-------
Minor JS issue
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4f73ef8
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8ee8e87
Diff: https://reviews.apache.org/r/56483/diff/
Testing
-------
manuualy tested
Thanks,
Pallav Kulshreshtha