You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/25 13:39:00 UTC

[jira] [Commented] (FLINK-9949) Jepsen: Kill Flink processes when tearing down cluster

    [ https://issues.apache.org/jira/browse/FLINK-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555676#comment-16555676 ] 

ASF GitHub Bot commented on FLINK-9949:
---------------------------------------

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/6419

    [FLINK-9949][tests] Kill Flink processes in DB/teardown

    ## What is the purpose of the change
    
    *Not killing Flink processes at the end of a test, can cause interference with subsequent test runs.*
    
    ## Brief change log
      - *Kill Flink processes in `DB/teardown!`.*
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Ran tests in docker.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
    
    cc: @tillrohrmann 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-9949

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6419
    
----
commit db3cecb5c9fb16d707e02b436244ba8fd5ee1ce8
Author: gyao <ga...@...>
Date:   2018-07-25T13:28:40Z

    [FLINK-9949][tests] Kill Flink processes in DB/teardown

----


> Jepsen: Kill Flink processes when tearing down cluster
> ------------------------------------------------------
>
>                 Key: FLINK-9949
>                 URL: https://issues.apache.org/jira/browse/FLINK-9949
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.6.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> Because Flink processes are not killed at the end of the tests, it can happen that surviving instances create znodes in the ZooKeeper ensemble of the next test run. This creates ambiguity when we retrieve the address of the leading REST server from ZooKeeper.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)