You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/10/27 19:30:06 UTC
[GitHub] [activemq-artemis] gtully opened a new pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
gtully opened a new pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315
… connection state. consume via regular auth
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315#issuecomment-718575687
Thanks.
Good to see those tests, they nicely demonstrate the need for permissions on Advisories (ActiveMQ.Advisory.#) or avoiding their use via:
openwire connectionFactory.setWatchTopicAdvisories(false) or url parameter jms.watchTopicAdvisories=false
sorted with examples of each approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315#issuecomment-718247577
also on org.apache.activemq.artemis.tests.smoke.jmxmultiplefailback.ReplicatedMultipleFailbackTest.testMultipleFailback
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315#issuecomment-718247889
they seem test issues only... it seems the tests need to be adapted due to the changes you're making...
but still if you could handle it please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315#issuecomment-718247415
you had some real failures on this PR:
Test Name | Duration | Age
-- | -- | --
org.apache.activemq.artemis.tests.integration.security.SecurityPerAcceptorJmsTest.testJAASSecurityManagerAuthorizationNegative[protocol=OPENWIRE] | 0.12 sec | 1
org.apache.activemq.artemis.tests.integration.security.SecurityTest.testJAASSecurityManagerOpenWireNegative | 0.43 sec | 1
org.apache.activemq.artemis.tests.integration.security.SecurityTest.testJAASSecurityManagerAuthenticationWithCertsAndOpenWire | 0.24 sec | 1
org.apache.activemq.artemis.tests.integration.server.SecureConfigurationTest.testSecureDurableSubscriber[2: protocol=OPENWIRE] | 0.24 sec | 1
org.apache.activemq.artemis.tests.integration.server.SecureConfigurationTest.testSecureQueue[2: protocol=OPENWIRE]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic edited a comment on pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
clebertsuconic edited a comment on pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315#issuecomment-718247577
also on org.apache.activemq.artemis.tests.smoke.jmxmultiplefailback.ReplicatedMultipleFailbackTest.testMultipleFailback
although it could be non related.. but if you could keep an eye on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315#issuecomment-717962499
@gtully The pool itself can pool just things until certain length limits and its effectiveness really depends how much sharing affect temporal locality vs the capacity of the pool. In term of threading model, the pool is perfectly thread-safe, because isn't precise, so it should be fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3315: ARTEMIS-2964 - fire advisory messages via post office, independent of…
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3315:
URL: https://github.com/apache/activemq-artemis/pull/3315#issuecomment-717901963
@franz1981 the coreMessageObjectPools has now moved to be shared across AMQSession. I think that makes sense, it can be reused for advisories that will likely share the addresses. I wonder about the locality of an object pool, is it something you have thought about?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org