[GitHub] [superset] villebro commented on a diff in pull request #23604: fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #23604:
URL: https://github.com/apache/superset/pull/23604#discussion_r1159307910


##########
superset/reports/commands/execute.py:
##########
@@ -408,9 +408,11 @@ def _send(
             try:
                 if app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"]:
                     logger.info(
-                        "Would send notification for alert %s, to %s",
+                        "Would send notification for alert %s, to %s. "
+                        "%s is enabled, set it to False to send notifications.",
                         self._report_schedule.name,
                         recipient.recipient_config_json,
+                        app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"],

Review Comment:
   Would this not produce `True is enabled, set it to False to send notifications.`, as that's the value of the config param, not it's name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org