You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Steven Broadbridge (JIRA)" <ji...@apache.org> on 2008/08/13 19:50:44 UTC
[jira] Created: (SOLR-698) SpellCheckComponent should use the
queryString set in the ResponseBuilder
SpellCheckComponent should use the queryString set in the ResponseBuilder
-------------------------------------------------------------------------
Key: SOLR-698
URL: https://issues.apache.org/jira/browse/SOLR-698
Project: Solr
Issue Type: Improvement
Components: spellchecker
Reporter: Steven Broadbridge
SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the "q" parameter.
This will allow it to be used with query components besides QueryComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-698) SpellCheckComponent should use the
queryString set in the ResponseBuilder
Posted by "Steven Broadbridge (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Broadbridge updated SOLR-698:
------------------------------------
Attachment: SOLR-698.patch
> SpellCheckComponent should use the queryString set in the ResponseBuilder
> -------------------------------------------------------------------------
>
> Key: SOLR-698
> URL: https://issues.apache.org/jira/browse/SOLR-698
> Project: Solr
> Issue Type: Improvement
> Components: spellchecker
> Reporter: Steven Broadbridge
> Attachments: SOLR-698.patch
>
>
> SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the "q" parameter.
> This will allow it to be used with query components besides QueryComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-698) SpellCheckComponent should use the
queryString set in the ResponseBuilder
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622480#action_12622480 ]
Shalin Shekhar Mangar commented on SOLR-698:
--------------------------------------------
ResponseBuilder#setQueryString can be used by other components to change the query itself before it is passed down to SpellCheckComponent. Moreover all other components such as FacetComponent, QueryComponent and DebugComponent use the ResponseBuilder#getQueryString. I guess SpellCheckComponent should also do the same.
> SpellCheckComponent should use the queryString set in the ResponseBuilder
> -------------------------------------------------------------------------
>
> Key: SOLR-698
> URL: https://issues.apache.org/jira/browse/SOLR-698
> Project: Solr
> Issue Type: Improvement
> Components: spellchecker
> Reporter: Steven Broadbridge
> Attachments: SOLR-698.patch
>
>
> SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the "q" parameter.
> This will allow it to be used with query components besides QueryComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-698) SpellCheckComponent should use the
queryString set in the ResponseBuilder
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-698:
---------------------------------------
Fix Version/s: 1.3
Assignee: Shalin Shekhar Mangar
Priority: Minor (was: Major)
Affects Version/s: 1.3
> SpellCheckComponent should use the queryString set in the ResponseBuilder
> -------------------------------------------------------------------------
>
> Key: SOLR-698
> URL: https://issues.apache.org/jira/browse/SOLR-698
> Project: Solr
> Issue Type: Improvement
> Components: spellchecker
> Affects Versions: 1.3
> Reporter: Steven Broadbridge
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-698.patch
>
>
> SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the "q" parameter.
> This will allow it to be used with query components besides QueryComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-698) SpellCheckComponent should use the
queryString set in the ResponseBuilder
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622413#action_12622413 ]
Lars Kotthoff commented on SOLR-698:
------------------------------------
Isn't the queryString attribute of ResponseBuilder the same as CommonParams.Q? At least a quick review of the code suggests that it's only ever set to CommonParams.Q.
Could you elaborate on how this allows SpellCheckComponent to be used with more components? If you need a special spellcheck query you can specify spellcheck.q in the request.
> SpellCheckComponent should use the queryString set in the ResponseBuilder
> -------------------------------------------------------------------------
>
> Key: SOLR-698
> URL: https://issues.apache.org/jira/browse/SOLR-698
> Project: Solr
> Issue Type: Improvement
> Components: spellchecker
> Reporter: Steven Broadbridge
> Attachments: SOLR-698.patch
>
>
> SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the "q" parameter.
> This will allow it to be used with query components besides QueryComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-698) SpellCheckComponent should use the
queryString set in the ResponseBuilder
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-698.
----------------------------------------
Resolution: Fixed
Committed revision 685830.
Thanks Steven!
> SpellCheckComponent should use the queryString set in the ResponseBuilder
> -------------------------------------------------------------------------
>
> Key: SOLR-698
> URL: https://issues.apache.org/jira/browse/SOLR-698
> Project: Solr
> Issue Type: Improvement
> Components: spellchecker
> Affects Versions: 1.3
> Reporter: Steven Broadbridge
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-698.patch
>
>
> SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the "q" parameter.
> This will allow it to be used with query components besides QueryComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-698) SpellCheckComponent should use the
queryString set in the ResponseBuilder
Posted by "Steven Broadbridge (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622544#action_12622544 ]
Steven Broadbridge commented on SOLR-698:
-----------------------------------------
To answer Lars Kothoff's question:
Suppose you have an "advanced search" form with range queries defined by pairs of input fields and multiple query fields with "any word", "all words" and "exact phrase" selectors. Suppose further that you cannot, are not allowed to, and/or don't want to use JavaScript to assemble "q" on the client side. Then you would create a custom SearchComponent to assemble the query string in prepare() and call ResponseBuilder#setQueryString (process() will be a noop). The QueryComponent down the chain will do the search with the specified query instead of looking for it in "q". SpellCheckComponent should do the same. And now it does!
> SpellCheckComponent should use the queryString set in the ResponseBuilder
> -------------------------------------------------------------------------
>
> Key: SOLR-698
> URL: https://issues.apache.org/jira/browse/SOLR-698
> Project: Solr
> Issue Type: Improvement
> Components: spellchecker
> Affects Versions: 1.3
> Reporter: Steven Broadbridge
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-698.patch
>
>
> SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the "q" parameter.
> This will allow it to be used with query components besides QueryComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.