You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/05 16:04:27 UTC

[GitHub] [camel-k] squakez commented on pull request #3874: fix(e2e): use generated API methods

squakez commented on PR #3874:
URL: https://github.com/apache/camel-k/pull/3874#issuecomment-1337628367

   @phantomjinx, I had a further look and it seems that the "patch" scenario is already tested in https://github.com/apache/camel-k/blob/a82e464d3cea2b28a2068deb30dea35c5f394e76/e2e/global/common/scale_integration_test.go#L73
   I've tried to enable the `// +genclient:method=PatchScale,verb=get,subresource=patch,result=k8s.io/api/autoscaling/v1.Scale` but the generation is failing. Looking further on the test, it seems that the original goal of this test was to really test the getter and the setter of the autogenerated Integration Scale client. Is this correct @astefanutti? so, if it keeps failing we should find the reason why the autogenerated code is broken IMO.
   
   Are you okey on reverting these changes? what was the "well known" behavior you were trying to fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org