You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "simbadzina (via GitHub)" <gi...@apache.org> on 2023/04/11 00:53:03 UTC

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5536: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics #5534

simbadzina commented on code in PR #5536:
URL: https://github.com/apache/hadoop/pull/5536#discussion_r1162196442


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -851,8 +851,9 @@ protected synchronized int readWithStrategy(ReaderStrategy strategy)
                   locatedBlocks.getFileLength() - pos);
             }
           }
+          long beginRead = Time.monotonicNow();

Review Comment:
   Add time unit. `MS`



##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -1184,6 +1185,7 @@ void actualGetFromOneDataNode(final DNAddrPair datanode, final long startInBlk,
         ByteBuffer tmp = buf.duplicate();
         tmp.limit(tmp.position() + len);
         tmp = tmp.slice();
+        long beginRead = Time.monotonicNow();

Review Comment:
   Add unit, `MS`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org