You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/12/27 15:28:30 UTC
zeppelin git commit: [MINOR] fix: Initialize zeppelin var in
visualization/builtin/*.js
Repository: zeppelin
Updated Branches:
refs/heads/master 78425c4b2 -> fb4e3d2cf
[MINOR] fix: Initialize zeppelin var in visualization/builtin/*.js
### What is this PR for?
Fixed fragile code in src/app/visualization/bulitin This code causes loading errors as u can see the screenshot above. Especially in different loading system (e.g es6 import, require, webpack)
Let's initialize `zeppelin` var like other files do
- [visualization.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/visualization/visualization.js#L17)
- [tabledata.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/tabledata/tabledata.js#L17)
### What type of PR is it?
[Bug Fix]
### Todos
Nothing
### What is the Jira issue?
MINOR
### How should this be tested?
It's trivial.
### Screenshots (if appropriate)
<img width="1439" alt="screen shot 2016-12-24 at 12 34 35 am" src="https://cloud.githubusercontent.com/assets/4968473/21457826/602cf11e-c975-11e6-9974-bce5370a3833.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #1803 from 1ambda/fix/fragile-code-visualization-js and squashes the following commits:
4549fdc [1ambda] fix: Initialize zeppelin var
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/fb4e3d2c
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/fb4e3d2c
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/fb4e3d2c
Branch: refs/heads/master
Commit: fb4e3d2cfe719c5feb6f8c15cf6aa98195dd3f82
Parents: 78425c4
Author: 1ambda <1a...@gmail.com>
Authored: Sat Dec 24 01:05:22 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Tue Dec 27 07:28:28 2016 -0800
----------------------------------------------------------------------
.../src/app/visualization/builtins/visualization-areachart.js | 2 ++
.../src/app/visualization/builtins/visualization-barchart.js | 2 ++
.../src/app/visualization/builtins/visualization-linechart.js | 2 ++
.../src/app/visualization/builtins/visualization-nvd3chart.js | 2 ++
.../src/app/visualization/builtins/visualization-piechart.js | 2 ++
.../src/app/visualization/builtins/visualization-scatterchart.js | 2 ++
zeppelin-web/src/app/visualization/builtins/visualization-table.js | 2 ++
7 files changed, 14 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4e3d2c/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js b/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js
index 74660e9..b18c29e 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-areachart.js
@@ -14,6 +14,8 @@
'use strict';
+var zeppelin = zeppelin || {};
+
/**
* Visualize data in area chart
*/
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4e3d2c/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js b/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
index 809176d..5ef1926 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
@@ -14,6 +14,8 @@
'use strict';
+var zeppelin = zeppelin || {};
+
/**
* Visualize data in bar char
*/
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4e3d2c/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js b/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js
index f513a37..7e451aa 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-linechart.js
@@ -14,6 +14,8 @@
'use strict';
+var zeppelin = zeppelin || {};
+
/**
* Visualize data in line chart
*/
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4e3d2c/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js b/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js
index 5831a47..f1424be 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js
@@ -14,6 +14,8 @@
'use strict';
+var zeppelin = zeppelin || {};
+
/**
* Visualize data in table format
*/
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4e3d2c/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js b/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js
index d685cfd..3018810 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js
@@ -14,6 +14,8 @@
'use strict';
+var zeppelin = zeppelin || {};
+
/**
* Visualize data in pie chart
*/
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4e3d2c/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js b/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js
index 3dcf78c..87ee7ef 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-scatterchart.js
@@ -14,6 +14,8 @@
'use strict';
+var zeppelin = zeppelin || {};
+
/**
* Visualize data in scatter char
*/
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4e3d2c/zeppelin-web/src/app/visualization/builtins/visualization-table.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-table.js b/zeppelin-web/src/app/visualization/builtins/visualization-table.js
index 69a7938..552df7d 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-table.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-table.js
@@ -14,6 +14,8 @@
'use strict';
+var zeppelin = zeppelin || {};
+
/**
* Visualize data in table format
*/