You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/18 21:14:23 UTC

[GitHub] [beam] pabloem commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

pabloem commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely
URL: https://github.com/apache/beam/pull/11128#discussion_r394495708
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
 ##########
 @@ -153,7 +153,8 @@ def __init__(
     self._coder = coder
     self._labels = labels
     self._is_cache_complete = (
-        is_cache_complete if is_cache_complete else lambda: True)
+        is_cache_complete if is_cache_complete else lambda _: True)
+    self._pipeline_id = labels[-1].split('_')[-1]
 
 Review comment:
   what is a pipeline ID? Are you sure it's unique? I see elsewhere you're using the `id(..)` of the objects?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services