You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 04:56:29 UTC
[PR] [ISSUE #769] Stop fabricating proxy runtime metrics [rocketmq-dashboard]
Aias00 opened a new pull request, #770:
URL: https://github.com/apache/rocketmq-dashboard/pull/770
## Summary
- stop filling Proxy page runtime fields with randomized values
- mark proxy status/version/connections/TPS/CPU/memory/uptime as unavailable when the API only returns addresses
- keep proxy address loading, current-node selection, add/remove actions, and config unavailable modal behavior unchanged
- add coverage for the address-only API response so fake version/runtime values do not render
Fixes #769
## Verification
- `npm --prefix web test -- Proxy.test.tsx`
- `npm --prefix web exec -- eslint web/src/api/proxy.ts web/src/pages/studio/Proxy.tsx web/src/pages/studio/__tests__/Proxy.test.tsx`
- `(cd web && npx tsc -b --noEmit)`
## Notes
`npm ci` reports existing high severity audit findings in the dependency tree; this PR does not change dependencies or lock files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #769] Stop fabricating proxy runtime metrics [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #770:
URL: https://github.com/apache/rocketmq-dashboard/pull/770#issuecomment-5175475818
Superseded by consolidated PR #944, which contains this change and has passing checks. Closing this narrower PR to keep review focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #769] Stop fabricating proxy runtime metrics [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #770: [ISSUE #769] Stop fabricating proxy runtime metrics
URL: https://github.com/apache/rocketmq-dashboard/pull/770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #769] Stop fabricating proxy runtime metrics [rocketmq-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #770:
URL: https://github.com/apache/rocketmq-dashboard/pull/770#discussion_r3701414224
##########
web/src/pages/studio/Proxy.tsx:
##########
@@ -183,15 +183,28 @@ const ProxyPage: React.FC = () => {
icon: <Warning size={12} weight="fill" />,
label: t('proxy.warning'),
},
+ unknown: {
+ color: 'default',
+ icon: null,
+ label: t('common.na'),
+ },
};
- const cfg = map[status] || map.healthy;
+ const cfg = map[status] || map.unknown;
return (
<Tag color={cfg.color} icon={cfg.icon}>
{cfg.label}
</Tag>
);
};
+ const renderUnavailable = () => <Text type="secondary">{t('common.na')}</Text>;
+
+ const renderNumberMetric = (value: number | null) =>
+ value == null ? renderUnavailable() : value.toLocaleString();
+
+ const compareNullable = (left: number | null, right: number | null) =>
+ (left ?? Number.NEGATIVE_INFINITY) - (right ?? Number.NEGATIVE_INFINITY);
Review Comment:
`compareNullable` returns `NaN` when both values are `null` because `Number.NEGATIVE_INFINITY - Number.NEGATIVE_INFINITY` is `NaN`. Antd Table sorters expect a stable numeric comparator (negative/0/positive); `NaN` can lead to unpredictable sort behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org