[GitHub] ZiyueHuang commented on a change in pull request #9942: add SameType as default type inference function in imperative mode

[GitBox <gi...@apache.org>]

ZiyueHuang commented on a change in pull request #9942: add SameType as default type inference function in imperative mode
URL: https://github.com/apache/incubator-mxnet/pull/9942#discussion_r171659549
 
 

 ##########
 File path: src/executor/exec_pass.h
 ##########
 @@ -189,6 +189,13 @@ bool DefaultStorageType(const nnvm::NodeAttrs& attrs,
                         std::vector<int> *iattr,
                         std::vector<int> *oattr);
 
+/*! \brief The default type inference function, which assigns all undefined
+ *         types to the same type of one of the inputs or outputs.
+ */
+bool SameType(const nnvm::NodeAttrs& attrs,
 
 Review comment:
   I haven?t found the definition of SameType. It seems that this function is just defined and implemented in infer_graph_attr_pass.cc.
   
   A same kind of function, DefaultStorageType, is defined in this header and implemented in infer_graph_attr_pass.cc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services