You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by AndyG <an...@orprovision.com> on 2011/09/14 08:48:31 UTC

Replace 'openejb.math' with 'commons.math'

Changed serialVersionUIDs in 'org.apache.openejb.math' that conflict with
identical commons.math classes (from which they are copied). Not serious,
but intellij, netbeans and possibly other IDEs see these classes as the same
and can lead to incorrect imports.

Would it maybe be better to remove the 'org.apache.openejb.math' namespace
and pull in a dep on commons.math?

--
View this message in context: http://openejb.979440.n4.nabble.com/Replace-openejb-math-with-commons-math-tp3811951p3811951.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: Replace 'openejb.math' with 'commons.math'

Posted by AndyG <an...@orprovision.com>.
Sure, I guess openejb.math is unlikely to change a lot. Just one of our other
devs here pulled in openejb.math by mistake (SecondMoment.class) which broke
a unit test here. Was easy to fix and is why I changed the id's to avoid it
happening again.

--
View this message in context: http://openejb.979440.n4.nabble.com/Replace-openejb-math-with-commons-math-tp3811951p3812183.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: Replace 'openejb.math' with 'commons.math'

Posted by Romain Manni-Bucau <rm...@gmail.com>.
we should do assembles for that.

doing it can avoid to copy/paste classes and let us be up to date easily.

- Romain

2011/9/14 David Blevins <da...@gmail.com>

>
> On Sep 13, 2011, at 11:48 PM, AndyG wrote:
>
> > Changed serialVersionUIDs in 'org.apache.openejb.math' that conflict with
> > identical commons.math classes (from which they are copied). Not serious,
> > but intellij, netbeans and possibly other IDEs see these classes as the
> same
> > and can lead to incorrect imports.
> >
> > Would it maybe be better to remove the 'org.apache.openejb.math'
> namespace
> > and pull in a dep on commons.math?
>
> Only downside to that is we only need 58K out of the 965K commons-math jar.
>
> Would be great if we could trim the server down more doing the same thing.
>  That's how Tomcat got down to their very slim 7MB size.
>
>
> -David
>
>

Re: Replace 'openejb.math' with 'commons.math'

Posted by David Blevins <da...@gmail.com>.
On Sep 13, 2011, at 11:48 PM, AndyG wrote:

> Changed serialVersionUIDs in 'org.apache.openejb.math' that conflict with
> identical commons.math classes (from which they are copied). Not serious,
> but intellij, netbeans and possibly other IDEs see these classes as the same
> and can lead to incorrect imports.
> 
> Would it maybe be better to remove the 'org.apache.openejb.math' namespace
> and pull in a dep on commons.math?

Only downside to that is we only need 58K out of the 965K commons-math jar.

Would be great if we could trim the server down more doing the same thing.  That's how Tomcat got down to their very slim 7MB size.


-David