You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/05 06:19:46 UTC

[GitHub] [skywalking] LiWenGu commented on issue #6491: Why doesn’t JVMMetricsSender notify the status as DISCONNECT when sending a network error?

LiWenGu commented on issue #6491:
URL: https://github.com/apache/skywalking/issues/6491#issuecomment-791186045


   I mean, why not add reportError in line 86, like this:
   ```java
    catch (Throwable t) {
       LOGGER.error(t, "send JVM metrics to Collector fail.");
       ServiceManager.INSTANCE.findService(GRPCChannelManager.class).reportError(t);
   }
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org