[GitHub] [bookkeeper] wenbingshen commented on pull request #3505: Rename success with writableResult and update final writableResult about wait writeSet

[GitBox <gi...@apache.org>]

wenbingshen commented on PR #3505:
URL: https://github.com/apache/bookkeeper/pull/3505#issuecomment-1259267957

   > Are you only renaming a variable?
   
   No, i updated the title.
   
   > I think that adding a test is the maim content of this patch. Maybe we should change the title
   
   The code before this PR is like this:
   ```java
   while (!isWriteSetWritable(writeSet, allowedNonWritableCount)) {
              ...     
   }
   ```
   
   The code after this PR is this:
   ```java
   while (!(writableResult = isWriteSetWritable(writeSet, allowedNonWritableCount))) {
              ...     
   }
   ```
   writableResult will not update the last result, but this result needs to be used later, we should update it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org