You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by sansanichfb <gi...@git.apache.org> on 2016/12/07 00:34:47 UTC

[GitHub] incubator-hawq pull request #1041: HAWQ-1196. Added partitons support to Hiv...

GitHub user sansanichfb opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1041

    HAWQ-1196. Added partitons support to HiveOrc profile.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1196

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1041
    
----
commit 429deb3cccb7a6eb831f1bd9e2e6fe91a5b3592b
Author: Oleksandr Diachenko <od...@pivotal.io>
Date:   2016-12-07T00:33:03Z

    HAWQ-1196. Added partitons support to HiveOrc profile.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1041: HAWQ-1196. Added partitons support to Hiv...

Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1041


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1041: HAWQ-1196. Added partitons support to Hiv...

Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1041#discussion_r91362987
  
    --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveResolver.java ---
    @@ -254,16 +263,17 @@ void initPartitionFields() {
                                 "Unsupported partition type: " + type);
                 }
                 addOneFieldToRecord(partitionFields, convertedType, convertedValue);
    +            numberOfPartitions = partitionFields.size();
    --- End diff --
    
    You can instead just set numberOfPartitions after the for loop is complete


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---