You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/03/20 08:38:00 UTC
[jira] [Commented] (OFBIZ-9923) Propagate the theme in
DataResourceWorker.renderDataResourceAsText()
[ https://issues.apache.org/jira/browse/OFBIZ-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063173#comment-17063173 ]
ASF subversion and git services commented on OFBIZ-9923:
--------------------------------------------------------
Commit 6787d21522b5b2c3e378d466ea0131107989aac8 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6787d21 ]
Fixed: Propagate the theme in DataResourceWorker.renderDataResourceAsText()
Improved: no functional change
(OFBIZ-9923)
Seems that this has been fixed with OFBIZ-11466 "CommonTheme has a dependency on
Flatgrey application.js"
Thanks: Pierre Smits for the fix in OFBIZ-11466
> Propagate the theme in DataResourceWorker.renderDataResourceAsText()
> --------------------------------------------------------------------
>
> Key: OFBIZ-9923
> URL: https://issues.apache.org/jira/browse/OFBIZ-9923
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Priority: Minor
>
> This is due to OFBIZ-9138 I stumbled upon it while working on OFBIZ-9837 and explained things there:
> bq. I went to harcod the Flat Grey theme. This has no impact because no theme is really used by the online help which is a sole long page. But to be totally complete we should fix another issue from which this one stems from: the theme really used is no propagated in this method. There was already a FIXME about that, I put another one and linked both.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)