You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/08 23:14:21 UTC
[kudu-CR] log-rolling-itest: wait for log roller on server startup
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5431
to review the following change.
Change subject: log-rolling-itest: wait for log roller on server startup
......................................................................
log-rolling-itest: wait for log roller on server startup
The log roller runs early in the startup sequence, but we were still
hitting cases where the test outran the roller.
Change-Id: Iefbf678163c0f4ba07eedfd762177c5ace5e35e6
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/5431/1
--
To view, visit http://gerrit.cloudera.org:8080/5431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefbf678163c0f4ba07eedfd762177c5ace5e35e6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] log-rolling-itest: wait for log roller on server startup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: log-rolling-itest: wait for log roller on server startup
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbf678163c0f4ba07eedfd762177c5ace5e35e6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] log-rolling-itest: wait for log roller on server startup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: log-rolling-itest: wait for log roller on server startup
......................................................................
log-rolling-itest: wait for log roller on server startup
The log roller runs early in the startup sequence, but we were still
hitting cases where the test outran the roller.
Change-Id: Iefbf678163c0f4ba07eedfd762177c5ace5e35e6
Reviewed-on: http://gerrit.cloudera.org:8080/5431
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefbf678163c0f4ba07eedfd762177c5ace5e35e6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>