[jira] [Resolved] (FOP-2106) [PATCH] docbook footnote and body text overlap (example fo file included)

["Vincent Hennebert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FOP-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Hennebert resolved FOP-2106.
------------------------------------

    Resolution: Fixed

Hi Alexey,

thanks for your patch, and sorry about the delay for processing it.

I applied it in rev. 1530232. I made minor changes, mainly removed the change made in PageBreakingAlgorithm around line 645 (|| length < insertedFootnotesLength). I think we want to keep totalFootnotesLength here. Please let me know if you don't agree.

I also anonymised the test case a bit, and removed the one I had created to show a regression in your previous patch. I don't think it was worth including it.

Thanks!
Vincent

> [PATCH] docbook footnote and body text overlap (example fo file included)
> -------------------------------------------------------------------------
>
>                 Key: FOP-2106
>                 URL: https://issues.apache.org/jira/browse/FOP-2106
>             Project: Fop
>          Issue Type: Bug
>          Components: page-master/layout
>    Affects Versions: 1.0
>         Environment: Operating System: Linux
> Platform: PC
>            Reporter: Petter Reinholdtsen
>            Priority: Blocker
>         Attachments: bad-footnote.fo, fop-2106.diff, fop-2106.diff, totalFootnotesLength.fo
>
>
> I discovered this problem with the fop backend of xmlto when using it
> to create a PDF.  The docbook document in question is rather large,
> but I managed to extract an except demonstrating the problem.  The
> problem is that the footnote text and the body text overlap.  I
> initially reported it to Debian as
> <URL: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=683197 > but
> thought it best to report it here too.  The docbook source and the
> generated PDF is attached to the Debian bug report.  Notice in the
> example how the text of the footnote on the second to last page is
> overlapping with the body.
> I generated the PDF using this command:
>   xmlto --noautosize -m xmlto-pdf.xsl --with-fop pdf bad-footnote.xml
> The full document set is available from
> <URL: https://github.com/petterreinholdtsen/free-culture-lessig >, if
> you want to check it out.
> When I investigated some more, I concluded that the problem is with
> the fop processor, not xmlto.  The problem exist in both fop versions
> 1:0.95.dfsg-11 and 1:1.0.dfsg2-6 in Debian.  The fo code generated by
> xmlto include the footnote content as it should, and when I manually
> process the .fo file using fop, the resulting PDF have the overlapping
> text.
> I am attaching the .fo file I used to test this, to allow you to
> reproduce the problem and try to find a fix. :)
> Could this be the same problem reported in
> <URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=51304 >
> This issue make fop useless for making the PDF version of the Free
> Culture book. :(



--
This message was sent by Atlassian JIRA
(v6.1#6144)