You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bart Molenkamp (JIRA)" <ji...@apache.org> on 2007/12/12 08:15:43 UTC
[jira] Created: (WICKET-1220) Component.visitParents visits the
calling component as well
Component.visitParents visits the calling component as well
-----------------------------------------------------------
Key: WICKET-1220
URL: https://issues.apache.org/jira/browse/WICKET-1220
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-rc1
Environment: Windows XP, JDK 1.5.0_10
Reporter: Bart Molenkamp
I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1220:
---------------------------------------
Fix Version/s: (was: 1.4-M1)
1.4-M2
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Eelco Hillenius
> Fix For: 1.4-M2
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1220:
---------------------------------------
Fix Version/s: (was: 1.4-M2)
1.4-M3
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Eelco Hillenius
> Fix For: 1.4-M3
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1220:
----------------------------------
Fix Version/s: 1.4.0-alpha
Assignee: Eelco Hillenius
Affects Version/s: (was: 1.4.0-alpha)
1.3.0-rc3
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc3
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Eelco Hillenius
> Fix For: 1.4.0-alpha
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643983#action_12643983 ]
Igor Vaynberg commented on WICKET-1220:
---------------------------------------
i dont care which way we go but this issue has been open for a long time. you want roll it back and rename the method.
as far as i can see findparent() doesnt check the current class, but properly starts with the parent.
i think its really stupid that visitparents visits the current component, so -1 on just updating the javadocs. either leave it or rename the method.
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1220:
-------------------------------------
Fix Version/s: (was: 1.4-M3)
1.4-M4
Moved to next milestone release.
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Eelco Hillenius
> Fix For: 1.4-M4
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1220.
-----------------------------------
Resolution: Fixed
Assignee: Igor Vaynberg (was: Eelco Hillenius)
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1220:
----------------------------------
Affects Version/s: (was: 1.3.0-rc1)
1.4.0-alpha
too late to do this for 1.3
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.0-alpha
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1220:
---------------------------------------
Affects Version/s: (was: 1.3.0-rc3)
1.3.0-rc1
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Eelco Hillenius
> Fix For: 1.4.0-alpha
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1220) Component.visitParents visits the
calling component as well
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643810#action_12643810 ]
Johan Compagner commented on WICKET-1220:
-----------------------------------------
i dont know if i like this change
i like the behavior (we in servoy have the exact same things and we also start that the component you ask it for)
this could break a lot of code that depended on that the everything is checked
for example i do this in a behavior or something like that:
component.findParent(Form.class)
if you do that on a form class itself somehow then i expect to find it., after this change i have to manually check the component itself first.
I guess renaming would be better then: visitHierachy() or something like that
Also we do that now already for years (i think from the beginning) as far as i can see so this is quite a big behavior change. I dont like the behavior change and i like the previous implementation better anyway. (just update docs i would say)
> Component.visitParents visits the calling component as well
> -----------------------------------------------------------
>
> Key: WICKET-1220
> URL: https://issues.apache.org/jira/browse/WICKET-1220
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Environment: Windows XP, JDK 1.5.0_10
> Reporter: Bart Molenkamp
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
>
> I see that Component.visitParents() also visits the component on which the call is made. Is this behavior correct?
> If so, I think that the method name is a little bit confusing. The method MarkupContainer.visitChildren() doesn't visit the calling component, but only it's children (as the method name suggests).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.