You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/09 17:37:17 UTC

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KIP-405: Log layer refactor

kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-794210868


   @ijuma In this PR the intention was not to rename `Log` to `LocalLog`, but rather extract `LocalLog` class out of `Log`. My current plan is to do the alternative of what you had suggested above i.e. extract `LocalLog` from `Log` in this PR and then rename `Log` to `GlobalLog` in a subsequent PR. The reason is to focus on the more important/major piece in the first PR (which is the Log layer separation), then the renaming the abstractions in a future PR becomes a relatively minor activity. Either way we choose, we will eventually introduce a new abstraction viz. `LocalLog` or `GlobalLog`.
   
   Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org