You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by Roger Leigh <rl...@codelibre.net> on 2020/05/24 22:26:23 UTC

Xalan-C++ 1.12 release candidate 1

Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip 
archives, and the signed release tag.  The full documentation is at:

   https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, 
and it's now ready for wider testing. I would be very grateful if all 
Xalan-C++ users reading this could take the time to build and test it 
with your own code, and report back any successes or failures.  If any 
problems are found, we can investigate and fix them in an RC2, or defer 
to 1.13 if appropriate.  If we're confident that this is release-worthy, 
then I'll call for a vote and we can make the first Xalan-C++ release 
for nearly 8 years!


Kind regards,

Roger Leigh


Re: Xalan-C++ 1.12 release candidate 1

Posted by Roger Leigh <rl...@codelibre.net>.
Hi Rob,


Thanks for checking that.  This was a bug in the Xerces-C++ CMake build 
which got carried over to the Xalan-C++ CMake build.  I fixed this some 
time back for Xerces and didn't realise it was still being applied for 
Xalan.  I've opened a ticket (XALANC-807) and a PR to fix this, and some 
other cosmetic CMake details, and tested it with VS2019.  The changes 
are here: https://github.com/apache/xalan-c/pull/30/files


I'll make an RC2 tomorrow with this fix included.


Kind regards,

Roger


On 29/05/2020 19:16, Rob Conde wrote:
> I will double check, but just to clarify I was pointing to:
>
> set_target_properties(xalan-c PROPERTIES OUTPUT_NAME 
> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
>
> and in XalanDll.cmake you have:
>
> if(MSVC)
>   set(CMAKE_DEBUG_POSTFIX "D")
> endif()
>
> so it seems that the output name will unconditionally have a D 
> postfixed on windows.
>
> Rob
>
>
>
> ------------------------------------------------------------------------
> *From:* Roger Leigh <rl...@codelibre.net>
> *Sent:* Friday, May 29, 2020 1:22 PM
> *To:* c-users@xalan.apache.org <c-...@xalan.apache.org>; Rob Conde 
> <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>
> *Subject:* Re: Xalan-C++ 1.12 release candidate 1
>
> Hi Rob,
>
>
> I don't think this is a bug.  It only applies to debug builds, and 
> I've used this configuration in quite a few open source projects 
> without trouble including libtiff, xerces-c and others.  If you use 
> e.g. a multi-configuration generator like for Visual Studio, then the 
> DEBUG_POSTFIX applies to the debug variant(s) and not to the release 
> variant(s).
>
>
> Please could you run a release build with -DCMAKE_BUILD_TYPE=Release 
> and verify that the library name does not contain the suffix?
>
>
> Kind regards,
>
> Roger
>
>
>
> On 29/05/2020 13:47, Rob Conde wrote:
>> Hey Again Roger,
>>    Ok - now I think I found a straight-up bug (let me know if you 
>> want to handle this in a github issue instead).
>>
>>   set_target_properties(xalan-c PROPERTIES OUTPUT_NAME 
>> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
>>   set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME 
>> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
>>   set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX"D")
>>
>> You're always appending the CMAKE_DEBUG_POSTFIX, which means even the 
>> release dlls/libs are postfixed with D.
>>
>> Rob
>>
>>
>> ------------------------------------------------------------------------
>> *From:* Rob Conde <ro...@ai-solutions.com> 
>> <ma...@ai-solutions.com>
>> *Sent:* Friday, May 29, 2020 8:22 AM
>> *To:* xalan-dev@apache.org <ma...@apache.org> 
>> <xa...@apache.org> <ma...@apache.org>; 
>> c-users@xalan.apache.org <ma...@xalan.apache.org> 
>> <c-...@xalan.apache.org> <ma...@xalan.apache.org>
>> *Subject:* Re: Xalan-C++ 1.12 release candidate 1
>> Hey Roger,
>>    First thanks for your work! This release is actually very timely 
>> for me. I'm running into an issue when building against a shared 
>> xerces library. When the msgcreator is run it crashes because it 
>> can't find the xerces dll. I'm gonna try to handle this externally by 
>> updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the 
>> platform - but this might be better handled in the xalan cmake 
>> itself. I'm not entirely sure the conventions for this scenario.
>>
>> Thanks,
>> Rob
>> ------------------------------------------------------------------------
>> *From:* Roger Leigh <rl...@codelibre.net> <ma...@codelibre.net>
>> *Sent:* Sunday, May 24, 2020 6:26 PM
>> *To:* xalan-dev@apache.org <ma...@apache.org> 
>> <xa...@apache.org> <ma...@apache.org>; 
>> c-users@xalan.apache.org <ma...@xalan.apache.org> 
>> <c-...@xalan.apache.org> <ma...@xalan.apache.org>
>> *Subject:* Xalan-C++ 1.12 release candidate 1
>>
>> Dear all,
>>
>>
>> I have tagged and made a prerelease of 1.12 which can be obtained here:
>>
>> https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>>
>>
>> The above link includes the release notes, links to .tar.gz and .zip 
>> archives, and the signed release tag.  The full documentation is at:
>>
>> https://apache.github.io/xalan-c/ <https://apache.github.io/xalan-c/>
>>
>>
>> The current iteration fixes all of the major problems I was aware of, 
>> and it's now ready for wider testing.  I would be very grateful if 
>> all Xalan-C++ users reading this could take the time to build and 
>> test it with your own code, and report back any successes or 
>> failures.  If any problems are found, we can investigate and fix them 
>> in an RC2, or defer to 1.13 if appropriate.  If we're confident that 
>> this is release-worthy, then I'll call for a vote and we can make the 
>> first Xalan-C++ release for nearly 8 years!
>>
>>
>> Kind regards,
>>
>> Roger Leigh
>>

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
Ok - I can confirm that the D is there in release...and in fact there are 2 Ds in debug. FYI for visual studio (or any multi-config generator) you need to specify cmake .. --config Release instead of using -DCMAKE_BUILD_TYPE=Release.

Thanks,
Rob
________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 2:16 PM
To: Roger Leigh <rl...@codelibre.net>; c-users@xalan.apache.org <c-...@xalan.apache.org>; xalan-dev@apache.org <xa...@apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

I will double check, but just to clarify I was pointing to:

set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")

and in XalanDll.cmake you have:

if(MSVC)
  set(CMAKE_DEBUG_POSTFIX "D")
endif()

so it seems that the output name will unconditionally have a D postfixed on windows.

Rob



________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Friday, May 29, 2020 1:22 PM
To: c-users@xalan.apache.org <c-...@xalan.apache.org>; Rob Conde <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1


Hi Rob,


I don't think this is a bug.  It only applies to debug builds, and I've used this configuration in quite a few open source projects without trouble including libtiff, xerces-c and others.  If you use e.g. a multi-configuration generator like for Visual Studio, then the DEBUG_POSTFIX applies to the debug variant(s) and not to the release variant(s).


Please could you run a release build with -DCMAKE_BUILD_TYPE=Release and verify that the library name does not contain the suffix?


Kind regards,

Roger



On 29/05/2020 13:47, Rob Conde wrote:
Hey Again Roger,
   Ok - now I think I found a straight-up bug (let me know if you want to handle this in a github issue instead).

  set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX "D")

You're always appending the CMAKE_DEBUG_POSTFIX, which means even the release dlls/libs are postfixed with D.

Rob


________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 8:22 AM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Roger Leigh <rl...@codelibre.net>.
Hi Rob,


Thanks for checking that.  This was a bug in the Xerces-C++ CMake build 
which got carried over to the Xalan-C++ CMake build.  I fixed this some 
time back for Xerces and didn't realise it was still being applied for 
Xalan.  I've opened a ticket (XALANC-807) and a PR to fix this, and some 
other cosmetic CMake details, and tested it with VS2019.  The changes 
are here: https://github.com/apache/xalan-c/pull/30/files


I'll make an RC2 tomorrow with this fix included.


Kind regards,

Roger


On 29/05/2020 19:16, Rob Conde wrote:
> I will double check, but just to clarify I was pointing to:
>
> set_target_properties(xalan-c PROPERTIES OUTPUT_NAME 
> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
>
> and in XalanDll.cmake you have:
>
> if(MSVC)
>   set(CMAKE_DEBUG_POSTFIX "D")
> endif()
>
> so it seems that the output name will unconditionally have a D 
> postfixed on windows.
>
> Rob
>
>
>
> ------------------------------------------------------------------------
> *From:* Roger Leigh <rl...@codelibre.net>
> *Sent:* Friday, May 29, 2020 1:22 PM
> *To:* c-users@xalan.apache.org <c-...@xalan.apache.org>; Rob Conde 
> <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>
> *Subject:* Re: Xalan-C++ 1.12 release candidate 1
>
> Hi Rob,
>
>
> I don't think this is a bug.  It only applies to debug builds, and 
> I've used this configuration in quite a few open source projects 
> without trouble including libtiff, xerces-c and others.  If you use 
> e.g. a multi-configuration generator like for Visual Studio, then the 
> DEBUG_POSTFIX applies to the debug variant(s) and not to the release 
> variant(s).
>
>
> Please could you run a release build with -DCMAKE_BUILD_TYPE=Release 
> and verify that the library name does not contain the suffix?
>
>
> Kind regards,
>
> Roger
>
>
>
> On 29/05/2020 13:47, Rob Conde wrote:
>> Hey Again Roger,
>>    Ok - now I think I found a straight-up bug (let me know if you 
>> want to handle this in a github issue instead).
>>
>>   set_target_properties(xalan-c PROPERTIES OUTPUT_NAME 
>> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
>>   set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME 
>> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
>>   set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX"D")
>>
>> You're always appending the CMAKE_DEBUG_POSTFIX, which means even the 
>> release dlls/libs are postfixed with D.
>>
>> Rob
>>
>>
>> ------------------------------------------------------------------------
>> *From:* Rob Conde <ro...@ai-solutions.com> 
>> <ma...@ai-solutions.com>
>> *Sent:* Friday, May 29, 2020 8:22 AM
>> *To:* xalan-dev@apache.org <ma...@apache.org> 
>> <xa...@apache.org> <ma...@apache.org>; 
>> c-users@xalan.apache.org <ma...@xalan.apache.org> 
>> <c-...@xalan.apache.org> <ma...@xalan.apache.org>
>> *Subject:* Re: Xalan-C++ 1.12 release candidate 1
>> Hey Roger,
>>    First thanks for your work! This release is actually very timely 
>> for me. I'm running into an issue when building against a shared 
>> xerces library. When the msgcreator is run it crashes because it 
>> can't find the xerces dll. I'm gonna try to handle this externally by 
>> updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the 
>> platform - but this might be better handled in the xalan cmake 
>> itself. I'm not entirely sure the conventions for this scenario.
>>
>> Thanks,
>> Rob
>> ------------------------------------------------------------------------
>> *From:* Roger Leigh <rl...@codelibre.net> <ma...@codelibre.net>
>> *Sent:* Sunday, May 24, 2020 6:26 PM
>> *To:* xalan-dev@apache.org <ma...@apache.org> 
>> <xa...@apache.org> <ma...@apache.org>; 
>> c-users@xalan.apache.org <ma...@xalan.apache.org> 
>> <c-...@xalan.apache.org> <ma...@xalan.apache.org>
>> *Subject:* Xalan-C++ 1.12 release candidate 1
>>
>> Dear all,
>>
>>
>> I have tagged and made a prerelease of 1.12 which can be obtained here:
>>
>> https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>>
>>
>> The above link includes the release notes, links to .tar.gz and .zip 
>> archives, and the signed release tag.  The full documentation is at:
>>
>> https://apache.github.io/xalan-c/ <https://apache.github.io/xalan-c/>
>>
>>
>> The current iteration fixes all of the major problems I was aware of, 
>> and it's now ready for wider testing.  I would be very grateful if 
>> all Xalan-C++ users reading this could take the time to build and 
>> test it with your own code, and report back any successes or 
>> failures.  If any problems are found, we can investigate and fix them 
>> in an RC2, or defer to 1.13 if appropriate.  If we're confident that 
>> this is release-worthy, then I'll call for a vote and we can make the 
>> first Xalan-C++ release for nearly 8 years!
>>
>>
>> Kind regards,
>>
>> Roger Leigh
>>

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
Ok - I can confirm that the D is there in release...and in fact there are 2 Ds in debug. FYI for visual studio (or any multi-config generator) you need to specify cmake .. --config Release instead of using -DCMAKE_BUILD_TYPE=Release.

Thanks,
Rob
________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 2:16 PM
To: Roger Leigh <rl...@codelibre.net>; c-users@xalan.apache.org <c-...@xalan.apache.org>; xalan-dev@apache.org <xa...@apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

I will double check, but just to clarify I was pointing to:

set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")

and in XalanDll.cmake you have:

if(MSVC)
  set(CMAKE_DEBUG_POSTFIX "D")
endif()

so it seems that the output name will unconditionally have a D postfixed on windows.

Rob



________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Friday, May 29, 2020 1:22 PM
To: c-users@xalan.apache.org <c-...@xalan.apache.org>; Rob Conde <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1


Hi Rob,


I don't think this is a bug.  It only applies to debug builds, and I've used this configuration in quite a few open source projects without trouble including libtiff, xerces-c and others.  If you use e.g. a multi-configuration generator like for Visual Studio, then the DEBUG_POSTFIX applies to the debug variant(s) and not to the release variant(s).


Please could you run a release build with -DCMAKE_BUILD_TYPE=Release and verify that the library name does not contain the suffix?


Kind regards,

Roger



On 29/05/2020 13:47, Rob Conde wrote:
Hey Again Roger,
   Ok - now I think I found a straight-up bug (let me know if you want to handle this in a github issue instead).

  set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX "D")

You're always appending the CMAKE_DEBUG_POSTFIX, which means even the release dlls/libs are postfixed with D.

Rob


________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 8:22 AM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
I will double check, but just to clarify I was pointing to:

set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")

and in XalanDll.cmake you have:

if(MSVC)
  set(CMAKE_DEBUG_POSTFIX "D")
endif()

so it seems that the output name will unconditionally have a D postfixed on windows.

Rob



________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Friday, May 29, 2020 1:22 PM
To: c-users@xalan.apache.org <c-...@xalan.apache.org>; Rob Conde <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1


Hi Rob,


I don't think this is a bug.  It only applies to debug builds, and I've used this configuration in quite a few open source projects without trouble including libtiff, xerces-c and others.  If you use e.g. a multi-configuration generator like for Visual Studio, then the DEBUG_POSTFIX applies to the debug variant(s) and not to the release variant(s).


Please could you run a release build with -DCMAKE_BUILD_TYPE=Release and verify that the library name does not contain the suffix?


Kind regards,

Roger



On 29/05/2020 13:47, Rob Conde wrote:
Hey Again Roger,
   Ok - now I think I found a straight-up bug (let me know if you want to handle this in a github issue instead).

  set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX "D")

You're always appending the CMAKE_DEBUG_POSTFIX, which means even the release dlls/libs are postfixed with D.

Rob


________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 8:22 AM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
I will double check, but just to clarify I was pointing to:

set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")

and in XalanDll.cmake you have:

if(MSVC)
  set(CMAKE_DEBUG_POSTFIX "D")
endif()

so it seems that the output name will unconditionally have a D postfixed on windows.

Rob



________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Friday, May 29, 2020 1:22 PM
To: c-users@xalan.apache.org <c-...@xalan.apache.org>; Rob Conde <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1


Hi Rob,


I don't think this is a bug.  It only applies to debug builds, and I've used this configuration in quite a few open source projects without trouble including libtiff, xerces-c and others.  If you use e.g. a multi-configuration generator like for Visual Studio, then the DEBUG_POSTFIX applies to the debug variant(s) and not to the release variant(s).


Please could you run a release build with -DCMAKE_BUILD_TYPE=Release and verify that the library name does not contain the suffix?


Kind regards,

Roger



On 29/05/2020 13:47, Rob Conde wrote:
Hey Again Roger,
   Ok - now I think I found a straight-up bug (let me know if you want to handle this in a github issue instead).

  set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX "D")

You're always appending the CMAKE_DEBUG_POSTFIX, which means even the release dlls/libs are postfixed with D.

Rob


________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 8:22 AM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Roger Leigh <rl...@codelibre.net>.
Hi Rob,


I don't think this is a bug.  It only applies to debug builds, and I've 
used this configuration in quite a few open source projects without 
trouble including libtiff, xerces-c and others.  If you use e.g. a 
multi-configuration generator like for Visual Studio, then the 
DEBUG_POSTFIX applies to the debug variant(s) and not to the release 
variant(s).


Please could you run a release build with -DCMAKE_BUILD_TYPE=Release and 
verify that the library name does not contain the suffix?


Kind regards,

Roger



On 29/05/2020 13:47, Rob Conde wrote:
> Hey Again Roger,
>    Ok - now I think I found a straight-up bug (let me know if you want 
> to handle this in a github issue instead).
>
>   set_target_properties(xalan-c PROPERTIES OUTPUT_NAME 
> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
>   set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME 
> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
>   set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX"D")
>
> You're always appending the CMAKE_DEBUG_POSTFIX, which means even the 
> release dlls/libs are postfixed with D.
>
> Rob
>
>
> ------------------------------------------------------------------------
> *From:* Rob Conde <ro...@ai-solutions.com>
> *Sent:* Friday, May 29, 2020 8:22 AM
> *To:* xalan-dev@apache.org <xa...@apache.org>; 
> c-users@xalan.apache.org <c-...@xalan.apache.org>
> *Subject:* Re: Xalan-C++ 1.12 release candidate 1
> Hey Roger,
>    First thanks for your work! This release is actually very timely 
> for me. I'm running into an issue when building against a shared 
> xerces library. When the msgcreator is run it crashes because it can't 
> find the xerces dll. I'm gonna try to handle this externally by 
> updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the 
> platform - but this might be better handled in the xalan cmake itself. 
> I'm not entirely sure the conventions for this scenario.
>
> Thanks,
> Rob
> ------------------------------------------------------------------------
> *From:* Roger Leigh <rl...@codelibre.net>
> *Sent:* Sunday, May 24, 2020 6:26 PM
> *To:* xalan-dev@apache.org <xa...@apache.org>; 
> c-users@xalan.apache.org <c-...@xalan.apache.org>
> *Subject:* Xalan-C++ 1.12 release candidate 1
>
> Dear all,
>
>
> I have tagged and made a prerelease of 1.12 which can be obtained here:
>
> https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>
>
> The above link includes the release notes, links to .tar.gz and .zip 
> archives, and the signed release tag. The full documentation is at:
>
> https://apache.github.io/xalan-c/ <https://apache.github.io/xalan-c/>
>
>
> The current iteration fixes all of the major problems I was aware of, 
> and it's now ready for wider testing.  I would be very grateful if all 
> Xalan-C++ users reading this could take the time to build and test it 
> with your own code, and report back any successes or failures. If any 
> problems are found, we can investigate and fix them in an RC2, or 
> defer to 1.13 if appropriate.  If we're confident that this is 
> release-worthy, then I'll call for a vote and we can make the first 
> Xalan-C++ release for nearly 8 years!
>
>
> Kind regards,
>
> Roger Leigh
>

Re: Xalan-C++ 1.12 release candidate 1

Posted by Roger Leigh <rl...@codelibre.net>.
Hi Rob,


I don't think this is a bug.  It only applies to debug builds, and I've 
used this configuration in quite a few open source projects without 
trouble including libtiff, xerces-c and others.  If you use e.g. a 
multi-configuration generator like for Visual Studio, then the 
DEBUG_POSTFIX applies to the debug variant(s) and not to the release 
variant(s).


Please could you run a release build with -DCMAKE_BUILD_TYPE=Release and 
verify that the library name does not contain the suffix?


Kind regards,

Roger



On 29/05/2020 13:47, Rob Conde wrote:
> Hey Again Roger,
>    Ok - now I think I found a straight-up bug (let me know if you want 
> to handle this in a github issue instead).
>
>   set_target_properties(xalan-c PROPERTIES OUTPUT_NAME 
> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
>   set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME 
> "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
>   set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX"D")
>
> You're always appending the CMAKE_DEBUG_POSTFIX, which means even the 
> release dlls/libs are postfixed with D.
>
> Rob
>
>
> ------------------------------------------------------------------------
> *From:* Rob Conde <ro...@ai-solutions.com>
> *Sent:* Friday, May 29, 2020 8:22 AM
> *To:* xalan-dev@apache.org <xa...@apache.org>; 
> c-users@xalan.apache.org <c-...@xalan.apache.org>
> *Subject:* Re: Xalan-C++ 1.12 release candidate 1
> Hey Roger,
>    First thanks for your work! This release is actually very timely 
> for me. I'm running into an issue when building against a shared 
> xerces library. When the msgcreator is run it crashes because it can't 
> find the xerces dll. I'm gonna try to handle this externally by 
> updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the 
> platform - but this might be better handled in the xalan cmake itself. 
> I'm not entirely sure the conventions for this scenario.
>
> Thanks,
> Rob
> ------------------------------------------------------------------------
> *From:* Roger Leigh <rl...@codelibre.net>
> *Sent:* Sunday, May 24, 2020 6:26 PM
> *To:* xalan-dev@apache.org <xa...@apache.org>; 
> c-users@xalan.apache.org <c-...@xalan.apache.org>
> *Subject:* Xalan-C++ 1.12 release candidate 1
>
> Dear all,
>
>
> I have tagged and made a prerelease of 1.12 which can be obtained here:
>
> https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>
>
> The above link includes the release notes, links to .tar.gz and .zip 
> archives, and the signed release tag. The full documentation is at:
>
> https://apache.github.io/xalan-c/ <https://apache.github.io/xalan-c/>
>
>
> The current iteration fixes all of the major problems I was aware of, 
> and it's now ready for wider testing.  I would be very grateful if all 
> Xalan-C++ users reading this could take the time to build and test it 
> with your own code, and report back any successes or failures. If any 
> problems are found, we can investigate and fix them in an RC2, or 
> defer to 1.13 if appropriate.  If we're confident that this is 
> release-worthy, then I'll call for a vote and we can make the first 
> Xalan-C++ release for nearly 8 years!
>
>
> Kind regards,
>
> Roger Leigh
>

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
Hey Again Roger,
   Ok - now I think I found a straight-up bug (let me know if you want to handle this in a github issue instead).

  set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX "D")

You're always appending the CMAKE_DEBUG_POSTFIX, which means even the release dlls/libs are postfixed with D.

Rob


________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 8:22 AM
To: xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
Hey Again Roger,
   Ok - now I think I found a straight-up bug (let me know if you want to handle this in a github issue instead).

  set_target_properties(xalan-c PROPERTIES OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES RUNTIME_OUTPUT_NAME "Xalan-C_${XALAN_MS_LIB_MAJOR_VER}_${XALAN_MS_LIB_MINOR_VER}${CMAKE_DEBUG_POSTFIX}")
  set_target_properties(xalan-c PROPERTIES DEBUG_POSTFIX "D")

You're always appending the CMAKE_DEBUG_POSTFIX, which means even the release dlls/libs are postfixed with D.

Rob


________________________________
From: Rob Conde <ro...@ai-solutions.com>
Sent: Friday, May 29, 2020 8:22 AM
To: xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1

Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
That's reasonable...setting the library paths fixed it for me anyhow (although I have yet to test on mac). Re: msgCreator you'll certainly here no argument from me. Seems like an something implemented in anticipation for something that never did and likely never will happen.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Friday, May 29, 2020 1:19 PM
To: dev@xalan.apache.org <de...@xalan.apache.org>; Rob Conde <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1


Hi Rob,


The runtime path is outside the purview of cmake.  You've got to install and then set the platform-specific path to include the lib and/or bin directories as appropriate for the platform.  We have no control over that except for when running unit tests or samples with ctest, where we could add in any needed directories if cmake isn't already doing it.  Once it's installed, it's entirely in the hands of the sysadmin/developer/packager.


When it comes to the path for xerces-c, it's expected that this is already installed and appropriately configured in the environment prior to running CMake.  On Windows, I've even seen it copy the xerces DLL into the build tree to ensure that the executables are runnable.  Maybe we can do more, but for the CI testing I've done on Windows (with xerces-c provided by vcpkg), it's all worked as is.  If you want to share the details of your environment and a lot of the cmake run and build that would be useful.  However, a deeper question would be to ask if both the MsgCreator tool and XalanMsgLib library are needed at all.   There are no translations, and as far as I can see there never have been any.  It's en_US only.  It wouldn't take much to persude me that the entire lot could be stripped out given that it serves no practical purpose.  Not that I'm against translation at all, just that right now it's unused and quite complex for zero benefit.  If there are no objections, I'd be inclined to remove it for the following release.


Kind regards,

Roger


On 29/05/2020 13:22, Rob Conde wrote:
Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
That's reasonable...setting the library paths fixed it for me anyhow (although I have yet to test on mac). Re: msgCreator you'll certainly here no argument from me. Seems like an something implemented in anticipation for something that never did and likely never will happen.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Friday, May 29, 2020 1:19 PM
To: dev@xalan.apache.org <de...@xalan.apache.org>; Rob Conde <ro...@ai-solutions.com>; xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Re: Xalan-C++ 1.12 release candidate 1


Hi Rob,


The runtime path is outside the purview of cmake.  You've got to install and then set the platform-specific path to include the lib and/or bin directories as appropriate for the platform.  We have no control over that except for when running unit tests or samples with ctest, where we could add in any needed directories if cmake isn't already doing it.  Once it's installed, it's entirely in the hands of the sysadmin/developer/packager.


When it comes to the path for xerces-c, it's expected that this is already installed and appropriately configured in the environment prior to running CMake.  On Windows, I've even seen it copy the xerces DLL into the build tree to ensure that the executables are runnable.  Maybe we can do more, but for the CI testing I've done on Windows (with xerces-c provided by vcpkg), it's all worked as is.  If you want to share the details of your environment and a lot of the cmake run and build that would be useful.  However, a deeper question would be to ask if both the MsgCreator tool and XalanMsgLib library are needed at all.   There are no translations, and as far as I can see there never have been any.  It's en_US only.  It wouldn't take much to persude me that the entire lot could be stripped out given that it serves no practical purpose.  Not that I'm against translation at all, just that right now it's unused and quite complex for zero benefit.  If there are no objections, I'd be inclined to remove it for the following release.


Kind regards,

Roger


On 29/05/2020 13:22, Rob Conde wrote:
Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org<ma...@apache.org> <xa...@apache.org>; c-users@xalan.apache.org<ma...@xalan.apache.org> <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Roger Leigh <rl...@codelibre.net>.
Hi Rob,


The runtime path is outside the purview of cmake.  You've got to install 
and then set the platform-specific path to include the lib and/or bin 
directories as appropriate for the platform.  We have no control over 
that except for when running unit tests or samples with ctest, where we 
could add in any needed directories if cmake isn't already doing it.  
Once it's installed, it's entirely in the hands of the 
sysadmin/developer/packager.


When it comes to the path for xerces-c, it's expected that this is 
already installed and appropriately configured in the environment prior 
to running CMake.  On Windows, I've even seen it copy the xerces DLL 
into the build tree to ensure that the executables are runnable.  Maybe 
we can do more, but for the CI testing I've done on Windows (with 
xerces-c provided by vcpkg), it's all worked as is.  If you want to 
share the details of your environment and a lot of the cmake run and 
build that would be useful.  However, a deeper question would be to ask 
if both the MsgCreator tool and XalanMsgLib library are needed at all.   
There are no translations, and as far as I can see there never have been 
any.  It's en_US only.  It wouldn't take much to persude me that the 
entire lot could be stripped out given that it serves no practical 
purpose.  Not that I'm against translation at all, just that right now 
it's unused and quite complex for zero benefit.  If there are no 
objections, I'd be inclined to remove it for the following release.


Kind regards,

Roger


On 29/05/2020 13:22, Rob Conde wrote:
> Hey Roger,
>    First thanks for your work! This release is actually very timely 
> for me. I'm running into an issue when building against a shared 
> xerces library. When the msgcreator is run it crashes because it can't 
> find the xerces dll. I'm gonna try to handle this externally by 
> updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the 
> platform - but this might be better handled in the xalan cmake itself. 
> I'm not entirely sure the conventions for this scenario.
>
> Thanks,
> Rob
> ------------------------------------------------------------------------
> *From:* Roger Leigh <rl...@codelibre.net>
> *Sent:* Sunday, May 24, 2020 6:26 PM
> *To:* xalan-dev@apache.org <xa...@apache.org>; 
> c-users@xalan.apache.org <c-...@xalan.apache.org>
> *Subject:* Xalan-C++ 1.12 release candidate 1
>
> Dear all,
>
>
> I have tagged and made a prerelease of 1.12 which can be obtained here:
>
> https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>
>
> The above link includes the release notes, links to .tar.gz and .zip 
> archives, and the signed release tag.  The full documentation is at:
>
> https://apache.github.io/xalan-c/ <https://apache.github.io/xalan-c/>
>
>
> The current iteration fixes all of the major problems I was aware of, 
> and it's now ready for wider testing.  I would be very grateful if all 
> Xalan-C++ users reading this could take the time to build and test it 
> with your own code, and report back any successes or failures. If any 
> problems are found, we can investigate and fix them in an RC2, or 
> defer to 1.13 if appropriate.  If we're confident that this is 
> release-worthy, then I'll call for a vote and we can make the first 
> Xalan-C++ release for nearly 8 years!
>
>
> Kind regards,
>
> Roger Leigh
>

Re: Xalan-C++ 1.12 release candidate 1

Posted by Roger Leigh <rl...@codelibre.net>.
Hi Rob,


The runtime path is outside the purview of cmake.  You've got to install 
and then set the platform-specific path to include the lib and/or bin 
directories as appropriate for the platform.  We have no control over 
that except for when running unit tests or samples with ctest, where we 
could add in any needed directories if cmake isn't already doing it.  
Once it's installed, it's entirely in the hands of the 
sysadmin/developer/packager.


When it comes to the path for xerces-c, it's expected that this is 
already installed and appropriately configured in the environment prior 
to running CMake.  On Windows, I've even seen it copy the xerces DLL 
into the build tree to ensure that the executables are runnable.  Maybe 
we can do more, but for the CI testing I've done on Windows (with 
xerces-c provided by vcpkg), it's all worked as is.  If you want to 
share the details of your environment and a lot of the cmake run and 
build that would be useful.  However, a deeper question would be to ask 
if both the MsgCreator tool and XalanMsgLib library are needed at all.   
There are no translations, and as far as I can see there never have been 
any.  It's en_US only.  It wouldn't take much to persude me that the 
entire lot could be stripped out given that it serves no practical 
purpose.  Not that I'm against translation at all, just that right now 
it's unused and quite complex for zero benefit.  If there are no 
objections, I'd be inclined to remove it for the following release.


Kind regards,

Roger


On 29/05/2020 13:22, Rob Conde wrote:
> Hey Roger,
>    First thanks for your work! This release is actually very timely 
> for me. I'm running into an issue when building against a shared 
> xerces library. When the msgcreator is run it crashes because it can't 
> find the xerces dll. I'm gonna try to handle this externally by 
> updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the 
> platform - but this might be better handled in the xalan cmake itself. 
> I'm not entirely sure the conventions for this scenario.
>
> Thanks,
> Rob
> ------------------------------------------------------------------------
> *From:* Roger Leigh <rl...@codelibre.net>
> *Sent:* Sunday, May 24, 2020 6:26 PM
> *To:* xalan-dev@apache.org <xa...@apache.org>; 
> c-users@xalan.apache.org <c-...@xalan.apache.org>
> *Subject:* Xalan-C++ 1.12 release candidate 1
>
> Dear all,
>
>
> I have tagged and made a prerelease of 1.12 which can be obtained here:
>
> https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>
>
> The above link includes the release notes, links to .tar.gz and .zip 
> archives, and the signed release tag.  The full documentation is at:
>
> https://apache.github.io/xalan-c/ <https://apache.github.io/xalan-c/>
>
>
> The current iteration fixes all of the major problems I was aware of, 
> and it's now ready for wider testing.  I would be very grateful if all 
> Xalan-C++ users reading this could take the time to build and test it 
> with your own code, and report back any successes or failures. If any 
> problems are found, we can investigate and fix them in an RC2, or 
> defer to 1.13 if appropriate.  If we're confident that this is 
> release-worthy, then I'll call for a vote and we can make the first 
> Xalan-C++ release for nearly 8 years!
>
>
> Kind regards,
>
> Roger Leigh
>

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh

Re: Xalan-C++ 1.12 release candidate 1

Posted by Roger Leigh <rl...@codelibre.net>.
On 25/05/2020 04:11, Mukul Gandhi wrote:

> On Mon, May 25, 2020 at 3:56 AM Roger Leigh <rleigh@codelibre.net 
> <ma...@codelibre.net>> wrote:
>
>     I have tagged and made a prerelease of 1.12 which can be obtained
>     here:
>
>     https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>
> Looks like, I could spot minor typo on above mentioned page. The 
> edits/addition are suggested below within *...*
>
> Xalan-C++ *now* supports Microsoft Visual Studio 2019 and earlier via 
> the new CMake build ...
>
> Xalan-C++ now *also* supports building with C++11, C++14 and C++17.
>
Thanks, I've pushed fixes for these corrections.


Regards.

Roger


Re: Xalan-C++ 1.12 release candidate 1

Posted by Mukul Gandhi <mu...@apache.org>.
On Mon, May 25, 2020 at 8:41 AM Mukul Gandhi <mu...@apache.org> wrote:

Xalan-C++ *now* supports Microsoft Visual Studio 2019 and earlier via the
> new CMake build ...
>

This looks ok to me.


> Xalan-C++ now *also* supports building with C++11, C++14 and C++17.
>
(maybe word 'also' doesn't look appropriate. According to me, the revised
sentence should be, *Xalan-C++ now supports building with C++11, C++14 and
C++17.*)

These are minor issues, though.




-- 
Regards,
Mukul Gandhi

Re: Xalan-C++ 1.12 release candidate 1

Posted by Mukul Gandhi <mu...@apache.org>.
On Mon, May 25, 2020 at 3:56 AM Roger Leigh <rl...@codelibre.net> wrote:

> I have tagged and made a prerelease of 1.12 which can be obtained here:
>
>   https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1
>
Looks like, I could spot minor typo on above mentioned page. The
edits/addition are suggested below within *...*

Xalan-C++ *now* supports Microsoft Visual Studio 2019 and earlier via the
new CMake build ...

Xalan-C++ now *also* supports building with C++11, C++14 and C++17.



-- 
Regards,
Mukul Gandhi

Re: Xalan-C++ 1.12 release candidate 1

Posted by Rob Conde <ro...@ai-solutions.com>.
Hey Roger,
   First thanks for your work! This release is actually very timely for me. I'm running into an issue when building against a shared xerces library. When the msgcreator is run it crashes because it can't find the xerces dll. I'm gonna try to handle this externally by updating PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on the platform - but this might be better handled in the xalan cmake itself. I'm not entirely sure the conventions for this scenario.

Thanks,
Rob
________________________________
From: Roger Leigh <rl...@codelibre.net>
Sent: Sunday, May 24, 2020 6:26 PM
To: xalan-dev@apache.org <xa...@apache.org>; c-users@xalan.apache.org <c-...@xalan.apache.org>
Subject: Xalan-C++ 1.12 release candidate 1


Dear all,


I have tagged and made a prerelease of 1.12 which can be obtained here:

  https://github.com/apache/xalan-c/releases/tag/Xalan-C_1_12_0_RC1


The above link includes the release notes, links to .tar.gz and .zip archives, and the signed release tag.  The full documentation is at:

  https://apache.github.io/xalan-c/


The current iteration fixes all of the major problems I was aware of, and it's now ready for wider testing.  I would be very grateful if all Xalan-C++ users reading this could take the time to build and test it with your own code, and report back any successes or failures.  If any problems are found, we can investigate and fix them in an RC2, or defer to 1.13 if appropriate.  If we're confident that this is release-worthy, then I'll call for a vote and we can make the first Xalan-C++ release for nearly 8 years!


Kind regards,

Roger Leigh