You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Sepand M <se...@gmail.com> on 2006/08/25 00:43:36 UTC
Where to put new Callback and CallbackHandler classes
Hi,
For certificate authentication, I'm adding two classes:
JaasCertificateCallbackHandler and CertificateCallback.
I've placed these classes in activemq-core along with
JaasCredentialCallback, etc. The problem is that activemq-jaas needs
access to these classes (since I have a new LoginModule that uses
them) and maven complains that we can't have a circular dependency
between activemq-core and activemq-jaas.
So, should I move these classes into activemq-jass? Should I move all
Callback classes to activemq-jaas? Any other way of doing this?
Regards,
Sepand
Re: Where to put new Callback and CallbackHandler classes
Posted by James Strachan <ja...@gmail.com>.
Sounds fine to me.
On 8/26/06, Sepand M <se...@gmail.com> wrote:
> Hi again,
>
> After looking at things closer, I think that all callback handlers,
> etc (including existing ones) should be moved to the jaas module and
> all of the authentication brokers should stay where they are in core.
>
> The callbacks should move since they are no necessary for core and
> moving them fixes the circular dependancy problem.
>
> The brokers should remain since they are needed for the authorization
> broker to function (and i don't think authorization should be moved
> into jaas). This also allows the bean stuff to continue working.
>
> Any objections?
>
> On 8/25/06, Sepand M <se...@gmail.com> wrote:
> > Ok. So, to confirm, I shouldm ove all Jaas* classes to the jaas module?
> >
> > On 8/25/06, James Strachan <ja...@gmail.com> wrote:
> > > On 8/25/06, Sepand M <se...@gmail.com> wrote:
> > > > Well there's already a JaasAuthenticationBroker in core, shouldn't the
> > > > JaasCertificateAuthenticationBroker (that's the full name) be in the
> > > > same package?
> > >
> > > Sure
> > >
> > > > Also, would I still be able to use it easily (just by specifying it in
> > > > the config xml) if I move it to the jaas module?
> > >
> > > Yes.; though we might have to hack the xbean-plugin configuration in
> > > the activemq-core module to also search other modules to keep them all
> > > in the same namespace as right now the xbean plugin isn't too great at
> > > creating a single schema & document reference for multiple modules in
> > > a single namespace.
> > >
> > > FWIW I'd like activemq-core, activemq-ra, activemq-jaas and maybe
> > > activemq-optional all to be in the same namespace & schema &
> > > reference.
> > >
> > > e.g. right now the activemq-ra stuff is in a different namespace; when
> > > its only a couple of elements; we really should unify them all
> > > together.
> > > --
> > >
> > > James
> > > -------
> > > http://radio.weblogs.com/0112098/
> > >
> >
>
--
James
-------
http://radio.weblogs.com/0112098/
Re: Where to put new Callback and CallbackHandler classes
Posted by Sepand M <se...@gmail.com>.
Hi again,
After looking at things closer, I think that all callback handlers,
etc (including existing ones) should be moved to the jaas module and
all of the authentication brokers should stay where they are in core.
The callbacks should move since they are no necessary for core and
moving them fixes the circular dependancy problem.
The brokers should remain since they are needed for the authorization
broker to function (and i don't think authorization should be moved
into jaas). This also allows the bean stuff to continue working.
Any objections?
On 8/25/06, Sepand M <se...@gmail.com> wrote:
> Ok. So, to confirm, I shouldm ove all Jaas* classes to the jaas module?
>
> On 8/25/06, James Strachan <ja...@gmail.com> wrote:
> > On 8/25/06, Sepand M <se...@gmail.com> wrote:
> > > Well there's already a JaasAuthenticationBroker in core, shouldn't the
> > > JaasCertificateAuthenticationBroker (that's the full name) be in the
> > > same package?
> >
> > Sure
> >
> > > Also, would I still be able to use it easily (just by specifying it in
> > > the config xml) if I move it to the jaas module?
> >
> > Yes.; though we might have to hack the xbean-plugin configuration in
> > the activemq-core module to also search other modules to keep them all
> > in the same namespace as right now the xbean plugin isn't too great at
> > creating a single schema & document reference for multiple modules in
> > a single namespace.
> >
> > FWIW I'd like activemq-core, activemq-ra, activemq-jaas and maybe
> > activemq-optional all to be in the same namespace & schema &
> > reference.
> >
> > e.g. right now the activemq-ra stuff is in a different namespace; when
> > its only a couple of elements; we really should unify them all
> > together.
> > --
> >
> > James
> > -------
> > http://radio.weblogs.com/0112098/
> >
>
Re: Where to put new Callback and CallbackHandler classes
Posted by Sepand M <se...@gmail.com>.
Ok. So, to confirm, I shouldm ove all Jaas* classes to the jaas module?
On 8/25/06, James Strachan <ja...@gmail.com> wrote:
> On 8/25/06, Sepand M <se...@gmail.com> wrote:
> > Well there's already a JaasAuthenticationBroker in core, shouldn't the
> > JaasCertificateAuthenticationBroker (that's the full name) be in the
> > same package?
>
> Sure
>
> > Also, would I still be able to use it easily (just by specifying it in
> > the config xml) if I move it to the jaas module?
>
> Yes.; though we might have to hack the xbean-plugin configuration in
> the activemq-core module to also search other modules to keep them all
> in the same namespace as right now the xbean plugin isn't too great at
> creating a single schema & document reference for multiple modules in
> a single namespace.
>
> FWIW I'd like activemq-core, activemq-ra, activemq-jaas and maybe
> activemq-optional all to be in the same namespace & schema &
> reference.
>
> e.g. right now the activemq-ra stuff is in a different namespace; when
> its only a couple of elements; we really should unify them all
> together.
> --
>
> James
> -------
> http://radio.weblogs.com/0112098/
>
Re: Where to put new Callback and CallbackHandler classes
Posted by James Strachan <ja...@gmail.com>.
On 8/25/06, Sepand M <se...@gmail.com> wrote:
> Well there's already a JaasAuthenticationBroker in core, shouldn't the
> JaasCertificateAuthenticationBroker (that's the full name) be in the
> same package?
Sure
> Also, would I still be able to use it easily (just by specifying it in
> the config xml) if I move it to the jaas module?
Yes.; though we might have to hack the xbean-plugin configuration in
the activemq-core module to also search other modules to keep them all
in the same namespace as right now the xbean plugin isn't too great at
creating a single schema & document reference for multiple modules in
a single namespace.
FWIW I'd like activemq-core, activemq-ra, activemq-jaas and maybe
activemq-optional all to be in the same namespace & schema &
reference.
e.g. right now the activemq-ra stuff is in a different namespace; when
its only a couple of elements; we really should unify them all
together.
--
James
-------
http://radio.weblogs.com/0112098/
Re: Where to put new Callback and CallbackHandler classes
Posted by Sepand M <se...@gmail.com>.
Well there's already a JaasAuthenticationBroker in core, shouldn't the
JaasCertificateAuthenticationBroker (that's the full name) be in the
same package?
Also, would I still be able to use it easily (just by specifying it in
the config xml) if I move it to the jaas module?
On 8/25/06, James Strachan <ja...@gmail.com> wrote:
> On 8/25/06, Sepand M <se...@gmail.com> wrote:
> > It does since the CertificateAuthenticationBroker I'm making will need
> > to use the CertificateCallbacks.
> > I have put the classes in jaas (core already has a dependancy on jaas
> > so that's not a problem). I do think the other callbacks should go in
> > jass now, but I don't want to touch your stuff since I'm not sure
> > when/if you will accept my patch.
>
> Since its all JAAS/security related and to avoid recursive
> dependencies, how about putting the CertificateAuthenticationBroker in
> the activemq-jaas module too? The idea behind activemq-core is that it
> has as few dependencies as possible.
>
> Which reminds me - it might be nice to remove the dependency on
> activeio and make that an optional module.
> --
>
> James
> -------
> http://radio.weblogs.com/0112098/
>
Re: Where to put new Callback and CallbackHandler classes
Posted by Hiram Chirino <hi...@hiramchirino.com>.
I've created http://issues.apache.org/activemq/browse/AMQ-907 to track this.
On 8/31/06, Hiram Chirino <hi...@hiramchirino.com> wrote:
> I'm 100% behind making activeio an optional module. I'll start
> working on moving some core classes that are in activeio to activemq
> so that it is not needed to run. Right now the only real
> functionality that it provides that is optional is the journal
> implementation.
>
> Everything else that is use are just abstract interfaces, and I think
> those need to be moved/copied to ActiveMQ.
>
> On 8/25/06, James Strachan <ja...@gmail.com> wrote:
> > On 8/25/06, Sepand M <se...@gmail.com> wrote:
> > > It does since the CertificateAuthenticationBroker I'm making will need
> > > to use the CertificateCallbacks.
> > > I have put the classes in jaas (core already has a dependancy on jaas
> > > so that's not a problem). I do think the other callbacks should go in
> > > jass now, but I don't want to touch your stuff since I'm not sure
> > > when/if you will accept my patch.
> >
> > Since its all JAAS/security related and to avoid recursive
> > dependencies, how about putting the CertificateAuthenticationBroker in
> > the activemq-jaas module too? The idea behind activemq-core is that it
> > has as few dependencies as possible.
> >
> > Which reminds me - it might be nice to remove the dependency on
> > activeio and make that an optional module.
> > --
> >
> > James
> > -------
> > http://radio.weblogs.com/0112098/
> >
>
>
> --
> Regards,
> Hiram
>
> Blog: http://hiramchirino.com
>
--
Regards,
Hiram
Blog: http://hiramchirino.com
Re: Where to put new Callback and CallbackHandler classes
Posted by Rob Davies <ra...@gmail.com>.
+1 to that!
On 31 Aug 2006, at 18:25, Hiram Chirino wrote:
> I'm 100% behind making activeio an optional module. I'll start
> working on moving some core classes that are in activeio to activemq
> so that it is not needed to run. Right now the only real
> functionality that it provides that is optional is the journal
> implementation.
>
> Everything else that is use are just abstract interfaces, and I think
> those need to be moved/copied to ActiveMQ.
>
> On 8/25/06, James Strachan <ja...@gmail.com> wrote:
>> On 8/25/06, Sepand M <se...@gmail.com> wrote:
>> > It does since the CertificateAuthenticationBroker I'm making
>> will need
>> > to use the CertificateCallbacks.
>> > I have put the classes in jaas (core already has a dependancy on
>> jaas
>> > so that's not a problem). I do think the other callbacks should
>> go in
>> > jass now, but I don't want to touch your stuff since I'm not sure
>> > when/if you will accept my patch.
>>
>> Since its all JAAS/security related and to avoid recursive
>> dependencies, how about putting the
>> CertificateAuthenticationBroker in
>> the activemq-jaas module too? The idea behind activemq-core is
>> that it
>> has as few dependencies as possible.
>>
>> Which reminds me - it might be nice to remove the dependency on
>> activeio and make that an optional module.
>> --
>>
>> James
>> -------
>> http://radio.weblogs.com/0112098/
>>
>
>
> --
> Regards,
> Hiram
>
> Blog: http://hiramchirino.com
Re: Where to put new Callback and CallbackHandler classes
Posted by Hiram Chirino <hi...@hiramchirino.com>.
I'm 100% behind making activeio an optional module. I'll start
working on moving some core classes that are in activeio to activemq
so that it is not needed to run. Right now the only real
functionality that it provides that is optional is the journal
implementation.
Everything else that is use are just abstract interfaces, and I think
those need to be moved/copied to ActiveMQ.
On 8/25/06, James Strachan <ja...@gmail.com> wrote:
> On 8/25/06, Sepand M <se...@gmail.com> wrote:
> > It does since the CertificateAuthenticationBroker I'm making will need
> > to use the CertificateCallbacks.
> > I have put the classes in jaas (core already has a dependancy on jaas
> > so that's not a problem). I do think the other callbacks should go in
> > jass now, but I don't want to touch your stuff since I'm not sure
> > when/if you will accept my patch.
>
> Since its all JAAS/security related and to avoid recursive
> dependencies, how about putting the CertificateAuthenticationBroker in
> the activemq-jaas module too? The idea behind activemq-core is that it
> has as few dependencies as possible.
>
> Which reminds me - it might be nice to remove the dependency on
> activeio and make that an optional module.
> --
>
> James
> -------
> http://radio.weblogs.com/0112098/
>
--
Regards,
Hiram
Blog: http://hiramchirino.com
Re: Where to put new Callback and CallbackHandler classes
Posted by James Strachan <ja...@gmail.com>.
On 8/25/06, Sepand M <se...@gmail.com> wrote:
> It does since the CertificateAuthenticationBroker I'm making will need
> to use the CertificateCallbacks.
> I have put the classes in jaas (core already has a dependancy on jaas
> so that's not a problem). I do think the other callbacks should go in
> jass now, but I don't want to touch your stuff since I'm not sure
> when/if you will accept my patch.
Since its all JAAS/security related and to avoid recursive
dependencies, how about putting the CertificateAuthenticationBroker in
the activemq-jaas module too? The idea behind activemq-core is that it
has as few dependencies as possible.
Which reminds me - it might be nice to remove the dependency on
activeio and make that an optional module.
--
James
-------
http://radio.weblogs.com/0112098/
Re: Where to put new Callback and CallbackHandler classes
Posted by Sepand M <se...@gmail.com>.
It does since the CertificateAuthenticationBroker I'm making will need
to use the CertificateCallbacks.
I have put the classes in jaas (core already has a dependancy on jaas
so that's not a problem). I do think the other callbacks should go in
jass now, but I don't want to touch your stuff since I'm not sure
when/if you will accept my patch.
On 8/24/06, James Strachan <ja...@gmail.com> wrote:
> On 8/24/06, Sepand M <se...@gmail.com> wrote:
> > Hi,
> >
> > For certificate authentication, I'm adding two classes:
> > JaasCertificateCallbackHandler and CertificateCallback.
> > I've placed these classes in activemq-core along with
> > JaasCredentialCallback, etc. The problem is that activemq-jaas needs
> > access to these classes (since I have a new LoginModule that uses
> > them) and maven complains that we can't have a circular dependency
> > between activemq-core and activemq-jaas.
> > So, should I move these classes into activemq-jass? Should I move all
> > Callback classes to activemq-jaas? Any other way of doing this?
>
> I'd put them in the module which uses them, so activemq-jaas sounds
> about right. Does activemq-core need to access them?
> --
>
> James
> -------
> http://radio.weblogs.com/0112098/
>
Re: Where to put new Callback and CallbackHandler classes
Posted by James Strachan <ja...@gmail.com>.
On 8/24/06, Sepand M <se...@gmail.com> wrote:
> Hi,
>
> For certificate authentication, I'm adding two classes:
> JaasCertificateCallbackHandler and CertificateCallback.
> I've placed these classes in activemq-core along with
> JaasCredentialCallback, etc. The problem is that activemq-jaas needs
> access to these classes (since I have a new LoginModule that uses
> them) and maven complains that we can't have a circular dependency
> between activemq-core and activemq-jaas.
> So, should I move these classes into activemq-jass? Should I move all
> Callback classes to activemq-jaas? Any other way of doing this?
I'd put them in the module which uses them, so activemq-jaas sounds
about right. Does activemq-core need to access them?
--
James
-------
http://radio.weblogs.com/0112098/