You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2015/12/08 23:58:30 UTC

Tabs in code are not allowed

There are now thousands of tabs in the JMeter code base.
These were all tidied up at one point.

Please would committers take care not to re-introduce them.

Re: Tabs in code are not allowed

Posted by Philippe Mouawad <ph...@gmail.com>.

On Sat, Dec 12, 2015 at 1:22 AM, sebb <se...@gmail.com> wrote:

> On 8 December 2015 at 22:58, sebb <se...@gmail.com> wrote:
> > There are now thousands of tabs in the JMeter code base.
> > These were all tidied up at one point.
> >
> > Please would committers take care not to re-introduce them.
>
> Thanks to Felix for fixing the tabs and indentation.
>
Thanks Felix

>
> However, there are now additional tabs in newly updated files.
>
It was me

>
> Please can committers check their IDE settings to make sure tabs are
> not re-introduced?
>
Fixed tabs and fixed IDE settings now.

> And if pull requests include tabs, please ask the author to fix them.
>

It was not the case


> Thanks.
>



-- 
Cordialement.
Philippe Mouawad.

Re: Tabs in code are not allowed

Posted by sebb <se...@gmail.com>.

On 8 December 2015 at 22:58, sebb <se...@gmail.com> wrote:
> There are now thousands of tabs in the JMeter code base.
> These were all tidied up at one point.
>
> Please would committers take care not to re-introduce them.

Thanks to Felix for fixing the tabs and indentation.

However, there are now additional tabs in newly updated files.

Please can committers check their IDE settings to make sure tabs are
not re-introduced?
And if pull requests include tabs, please ask the author to fix them.

Thanks.