[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #2870: Adjust pom plugin position and add docs

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #2870: Adjust pom plugin position and add docs
URL: https://github.com/apache/skywalking/pull/2870#discussion_r293412556
 
 

 ##########
 File path: docs/en/guides/How-to-build.md
 ##########
 @@ -142,5 +142,24 @@ a oap image with name `bar/oap:foo`, run the following command
 ```
 5. Run `./mvnw compile -Dmaven.test.skip=true`
 6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the complie)
-7. Run `./mvnw compile` complie collector-remote-grpc-provider and apm-protocol
+7. Run `./mvnw compile` compile collector-remote-grpc-provider and apm-protocol
 8. Refresh project
+
+## Write necessary tests and run them
 
 Review comment:
   Added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services