You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/11 04:50:19 UTC

[GitHub] [hudi] SoldierZh commented on a change in pull request #3173: [HUDI-1951] Add bucket hash index, compatible with the hive bucket

SoldierZh commented on a change in pull request #3173:
URL: https://github.com/apache/hudi/pull/3173#discussion_r686488735



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -933,6 +933,10 @@ public boolean getGlobalSimpleIndexUpdatePartitionPath() {
     return getBoolean(HoodieIndexConfig.SIMPLE_INDEX_UPDATE_PARTITION_PATH);
   }
 
+  public int getNumBuckets() {
+    return Integer.parseInt(props.getProperty(HoodieIndexConfig.BUCKET_INDEX_BUCKET_NUM.key(), "-1"));

Review comment:
       Can we use the `BUCKET_INDEX_BUCKET_NUM.defaultValue()` here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org